[mozlog.structured] formatter modules have non-working __main__ sections

RESOLVED FIXED in mozilla33

Status

Testing
Mozbase
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ted, Assigned: jgraham)

Tracking

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
All the structured logging formatter modules have a __main__ section that references a nonexistent base.format_file method:
http://hg.mozilla.org/mozilla-central/annotate/cbe4f69c2e9c/testing/mozbase/mozlog/mozlog/structured/formatters/html/html.py#l163

We should either fix that or remove it as it's confusing.
(Assignee)

Comment 1

4 years ago
Created attachment 8430153 [details] [diff] [review]
Add a 'structlog format' command for formatting logfiles.

This replaces the __main__ sections in the formatters
Attachment #8430153 - Flags: review?(wlachance)
Comment on attachment 8430153 [details] [diff] [review]
Add a 'structlog format' command for formatting logfiles.

Looks reasonable.
Attachment #8430153 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/7a5ae7eec2db
Assignee: nobody → james
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.