Closed Bug 1017103 Opened 10 years ago Closed 10 years ago

[B2G][Gaia] Improper data status in Utility Tray

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.3 unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.3 --- unaffected
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: bzumwalt, Assigned: gerard-majax)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(2 files)

Logcat
123.67 KB, text/plain
Details
Link to Github https://github.com/mozilla-b2g/gaia/pull/19810
46 bytes, text/x-github-pull-request
timdream
: review+
rmacdonald
: ui-review+
Details | Review
Attached file Logcat — 
Description:
With notification tray pulled down, enabling airplane mode causes 3G data icon ("H") to change to 2.75G EDGE icon ("E"). Disabling airplane mode reverts icon back to "H". Used AT&T SIM.

Repro Steps:
1) Updated Flame to BuildID: 20140528000201 using OTA
2) With SIM in 3G slot and data enabled, pull down notification tray
3) Enable airplane mode

Actual:
Toggling airplane mode changes data icon to different mode.

Expected:
Toggling airplane mode does not change data icon to different mode.

Environmental Variables:
Device: Flame v1.4 Mozilla RIL
BuildID: 20140528000201
Gaia: cd595be0a8e975559e8938830df5face89bec3e8
Gecko: af180db8a4bf
Version: 30.0
Firmware Version: v10G-2

Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Does this reproduce on 1.3 & does this reproduce on other devices?
Component: Gaia → Gaia::System
Keywords: qawanted
Here are the devices and builds where the bug repros.


2.0 Flame
Environmental Variables
Device: Flame 2.0
Build ID: 20140528040205
Gecko: https://hg.mozilla.org/mozilla-central/rev/e017c15325ae
Gaia: bc6f07c149770c6e6dfbea941ac65138dc364a15
Platform Version: 32.0a1
Firmware Version: v10G-2

2.0 Buri
Environmental Variables
Device: Buri v2.0
Build ID: 20140528040205
Gecko: https://hg.mozilla.org/mozilla-central/rev/e017c15325ae
Gaia: bc6f07c149770c6e6dfbea941ac65138dc364a15
Platform Version: 32.0a1
Firmware Version: v1.2-device.cfg

-----------------------------------------------

The bug does NOT repro on the following devices/builds


1.3 Buri

Environmental Variables
Device: Buri v1.3
Build ID: 20140528024003
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ce0dd450bffb
Gaia: 0ce948e378cab7ed3db20231281dd7ca2eb99779
Platform Version: 28.0
Firmware Version: v1.2-device.cfg

2.0 Open C
Environmental Variables
Device: OpenC v2.0
Build ID: 20140505103002
Gecko: https://hg.mozilla.org/mozilla-central/rev/2897fb554990
Gaia: e8a08a3f7a608993f0b302371e016e73faceea70
Platform Version: 32.0a1
Firmware Version: P821A10v1.0.0B06_LOG_DL

(There is a bug for the OpenC that causes it not to support 3g which is why it probably is not happening on the 2.0 version of OpenC.) https://bugzilla.mozilla.org/show_bug.cgi?id=1007439
status-b2g-v1.3: --- → unaffected
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → affected
Keywords: qawanted
QA Contact: croesch
Bug does NOT happen on OpenC 1.3

Environmental Variables
Device: OpenC v1.3 base
Build ID: 20140505052400
Gecko: /rev/
Gaia: Unknown Git commit; build date shown her
Platform Version: 28.0
Firmware Version: P821A10v1.0.0B06_LOG_DL
Pretty sure this would be a cert issue because we're showing the wrong mobile data info.
blocking-b2g: --- → 1.4?
Keywords: regression, regressionwindow-wanted
Gregor,

Can you please look into this?
blocking-b2g: 1.4? → 1.4+
Flags: needinfo?(anygregor)
Alex can you take a look here?
Flags: needinfo?(anygregor) → needinfo?(lissyx+mozillians)
Whiteboard: [systemsfe]
The video & the STR here don't match up. The video points to a temporary flash of E, where as the bug describes a permanent showing of E. Can we get this clarified?
Keywords: regressionwindow-wanted → qawanted
The video shows enabling airplane mode 'change to 2.75G EDGE icon ("E")' [at 0:01], then disabling airplane mode 'reverts icon back to "H"' [at 0:06]. STR and video match.
Keywords: qawanted → regressionwindow-wanted
Just to further clarify, 'E' remains as long as airplane mode is enabled.
Analyzing this more the STR isn't clear on the problem here actually. What E are you referring to? In what UX?
Keywords: regressionwindow-wanted → qawanted
(In reply to Brogan Zumwalt from comment #10)
> Just to further clarify, 'E' remains as long as airplane mode is enabled.

Displaying 'E' is even wrong for me. FYI on my Nexus S running 2.0 from today, before I switch to airplane mode, the icon was "3G", and it was still "3G" after.
(In reply to Gregor Wagner [:gwagner] from comment #7)
> Alex can you take a look here?

Will do tomorrow.
Assignee: nobody → lissyx+mozillians
Flags: needinfo?(lissyx+mozillians)
to clarify what happens here:

1. the user have configured their device for 3G (H) cell data
2. the user pull downs the notification/utility tray and enable airplane mode

Expected: the icon 'H' will gray out
Actual:   the icon grays out but it also turns to 'E' 

**It only can be seen in notification/utility tray.
**It only happens when enabling airplane mode, if the user simply disable cell data from the utility tray (w/o interacting with airplane mode) the 'H' will just gray out and won't change to 'E'
We should rather show "<>". Showing a radio tech makes no sense when in airplane mode.
Reproducing on Flame.
Please find attached a link to the github pull request that fixes the issue. The image defining the differents sprites being used by the CSS contains an icon for the case when we are in airplane mode, but this was not used. This patch makes use of it.

I don't see, however, a way to test this: there is already coverage for the dataset.network value, what we would need to test is the css applied itself. Do we have a way to do this?
Attachment #8431393 - Flags: review?(timdream)
Comment on attachment 8431393 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19810

The code looks fine. However let's loop UX to see if the spec indeed have defined this scenario and we are indeed using the right icon.
Attachment #8431393 - Flags: ui-review?(fdjabri)
Attachment #8431393 - Flags: review?(timdream)
Attachment #8431393 - Flags: review+
This is not related to airplane mode at all, this also reproduces when you don't have a SIM card.
Summary: [B2G][Gaia] Enabling and disabling airplane mode in notification tray shows different cell data modes in UI → [B2G][Gaia] Improper data status in Utility Tray
Stephany, can you help us getting a fast UX review ? It's quite urgent :) Thanks!
Flags: needinfo?(swilkes)
Hey there - I was on PTO the day you flagged me, so please use the general FFOS UX flag. That way, someone else sees it when I'm out. I see that Francis is already flagged but he was en route to India for user research, so the general flag on reviews is better there too. Will get someone else to take this up.
Flags: needinfo?(swilkes)
Comment on attachment 8431393 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19810

Flagging Rob on much needed ui-review? as Francis is in India for user research.
Attachment #8431393 - Flags: ui-review?(fdjabri) → ui-review?(rmacdonald)
Comment on attachment 8431393 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19810

Reviewed using airplane mode and using the generic connectivity indicator makes sense in this instance. Thanks!
Attachment #8431393 - Flags: ui-review?(rmacdonald) → ui-review+
https://github.com/mozilla-b2g/gaia/commit/312e1e3e7282265c433dbe08547d837776ab6f29
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: