Closed
Bug 1017132
Opened 10 years ago
Closed 10 years ago
Calling printf in FramePointerStackWalk isn't signal safe
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
846 bytes,
patch
|
BenWa
:
review+
dbaron
:
review+
|
Details | Diff | Splinter Review |
This avoids hangs while profiling
Attachment #8430200 -
Flags: review?(dbaron)
Attachment #8430200 -
Flags: review?(bgirard)
|
||
Updated•10 years ago
|
Attachment #8430200 -
Flags: review?(bgirard) → review+
Comment on attachment 8430200 [details] [diff] [review] Don't call printf in FramePointerStackWalk Maybe also remove the identical printf in unwind_callback?
Attachment #8430200 -
Flags: review?(dbaron) → review+
(Also, what's our Mac OS X version support these days? It looks like all of this IsCriticalAddress code is only needed for pre-Lion versions if I'm reading it correctly.)
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1012d031e19c
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•