Closed Bug 1017160 Opened 6 years ago Closed 6 years ago

remove certerror.xul and related unused cruft

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: keeler, Assigned: keeler)

Details

Attachments

(1 file)

certerror.xul is confusing and doesn't appear to actually be used. Removing it would also require removing nsISSLCertErrorDialog.showCertError / nsNSSDialogs::ShowCertError, which also isn't used, as far as I can tell.

11:37 grobinson | keeler: ping
11:37    keeler | grobinson: pong
11:37 grobinson | i'm looking at security/manager/pki/resources/content/certerror.xul
11:38 grobinson | Where/how are the "I understand the risks" / "get me out of here" buttons added?
11:38 grobinson | they are nowhere in certerror.{js,xul}
11:40    keeler | grobinson: I think browser/base/content/aboutcerterror/aboutCertError.xhtml might be the file
                | you're looking for?
11:41 grobinson | keeler: is that always used, instead of certerror.xul?
11:41    keeler | I think certerror.xul isn't actually used at all, which is about par for our security ui :(
11:42    keeler | grobinson: I believe so, yes
11:42 grobinson | cool, ok this makes more sense :)
11:43    keeler | :)
Attached patch patchSplinter Review
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8437344 - Flags: review?(cviecco)
Comment on attachment 8437344 [details] [diff] [review]
patch

Review of attachment 8437344 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like when https://bugzilla.mozilla.org/show_bug.cgi?id=431826 landed the certerror created by Kaie on ://bugzilla.mozilla.org/show_bug.cgi?id=439722 was never removed. Yay for removing old cruft.
Attachment #8437344 - Flags: review?(cviecco) → review+
https://hg.mozilla.org/mozilla-central/rev/fdd7d059ac9e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.