xpcshell/mail/steel/test/test_linux_platformChecks.js fails on Linux when gconf is disabled

RESOLVED FIXED in Thunderbird 32.0

Status

Thunderbird
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 32.0
x86
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.52 KB, patch
standard8
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
I have ac_add_options --disable-gconf in .mozconfig, then I get this failure permanently:

TEST-INFO | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | running test ...
TEST-UNEXPECTED-FAIL | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
TEST-UNEXPECTED-FAIL | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | false == true - See following stack:
JS frame :: /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js :: run_test :: line 11
JS frame :: /var/SSD/TB-hg/mozilla/testing/xpcshell/head.js :: _execute_test :: line 387
JS frame :: -e :: <TOP_LEVEL> :: line 1
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test

It is because steelApplication determines to be running under linux by checking if "gconf" exists in Components.classes. That does not seem right.
(Assignee)

Comment 1

4 years ago
Created attachment 8430244 [details] [diff] [review]
patch

This fixes it for me. We can't use Services.appinfo.OS as that returns "XPCShell" instead or real OS when running the test.
Attachment #8430244 - Flags: review?(standard8)

Comment 2

4 years ago
Or || @mozilla.org/gio-service;1 ?
(Assignee)

Comment 3

4 years ago
There doesn't seem to be such a thing.
And guess what, gio can be disabled too :)

Comment 4

4 years ago
Huh? "@mozilla.org/gio-service;1" in Components.classes is true for me

I was under the assumption you have to use one of them. "Have to" if you have the full build...

Comment 5

4 years ago
Remember solaris, openbsd and other platforms that want to be (in this context) counted as linux.
(Assignee)

Comment 6

4 years ago
Then they get caught by the gconf test ;) If they disable gconf then they are out of luck the same as Linux was before the patch. So they need to add their own test here.
Anyway, as you can see I add the gconf test in. So I expand it and count more systems as Linux (!gconf || Linux). I do not restrict it.

Comment 7

4 years ago
Yes, it's an improvement. I just suggested testing for gio-service too would be safer.
(Assignee)

Comment 8

4 years ago
Yes, if you meant it as an addition I can do it too. I just understood it as a replacement of gconf with gio (which wouldn't help me as I have that disabled too).
(Assignee)

Comment 9

4 years ago
Created attachment 8431644 [details] [diff] [review]
patch v2
Attachment #8430244 - Attachment is obsolete: true
Attachment #8430244 - Flags: review?(standard8)
Attachment #8431644 - Flags: review?(standard8)
Attachment #8431644 - Flags: review?(standard8) → review+
(Assignee)

Comment 10

4 years ago
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c01fd1da06d5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in before you can comment on or make changes to this bug.