Closed Bug 1017238 Opened 10 years ago Closed 3 years ago

Remove setLockingEnabled from TabsProvider and BrowserDatabaseHelper

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: bnicholson, Unassigned)

References

Details

<bnicholson> rnewman: do you know why we disable locking when we enable WAL here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/db/TabsProvider.java#158 ? and if we should be using setLockingEnabled at all, since it does nothing as of API level 16?
<rnewman> we also do it in BrowserDatabaseHelper
<rnewman> the idea is that with WAL you can achieve concurrency
<rnewman> for a brief period of history (11-16, I think), Android allowed you to turn off its built-in locking
<rnewman> so if your code is right, you can run parallel queries
<rnewman> so we turn off the locking if we can
<rnewman> note that this isn't necessarily a good idea, but that's why

Since setLockingEnabled does nothing in 16+, we should just remove these calls altogether for consistency and to avoid potentially obscure bugs in API levels 11-15.
Originally landed in bug 843005
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.