1017329 - Add data channel test which sends data from pcRemote to pcLocal

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Nils Ohlmeier [:drno]]

All data channel tests currently send only messages from pcLocal to pcRemote.
We need to add at least one test which tries to send data in the opposite direction as well.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1017329_data_channel_reverse_message.patch

This adds another simple step to the data channel tests to verify that the data channel is usable in the reverse direction as well.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=109c2d3b217d

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8430611 [details] [diff] [review]
bug_1017329_data_channel_reverse_message.patch

Note: the lower part is only fixing strange indentation with tabs oppose to spaces like in the rest of the file.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8430611 [details] [diff] [review]
bug_1017329_data_channel_reverse_message.patch

Review of attachment 8430611 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me and indeed makes sense to also test the other direction. Thanks Nils!

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fab17966aed

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fab17966aed