1017509 - [Download Manager] Deselect all button is not displayed successfully

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[rafael.marquez]

Attachment: deselect.png

*Procedure
1. Download a file
2. Open Settings app
3. Open Download list
4. Open edit mode

*Expected Result
"Deselect all" button is not displayed successfully. The user can't read the text "Deselect all"

*Actual Result
"Deselect all" button is displayed successfully

Comment 1

[Jason Smith [:jsmith]]

This was tested on 2.0, right?

QA Wanted to confirm this works on 1.4.

Comment 2

[rafael.marquez]

I have reviewed this feature in v1.4 and the bug is not reproduced

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Just double checking here, I'm testing on Buri 2.0, and I THINK this might be intended? Because the button to 'Deselect all' will become visible once I have one or more files actually selected in the list; and vice versa, if I have all files selected, the button to 'Select all' becomes non-readable.

I wouldn't consider this a bug, more like a feature, but I'll need confirmation.

Comment 4

[Jason Smith [:jsmith]]

Oh - good point. Yeah, this isn't a bug then.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Hey, the issue here is that the buttons container should be white, then the disabled button should be a bit more readable. This is because we have updated the buttons, and downloads is not using edit mode building block, but a custom implementation.
I would not close this bug, maybe we should rename it to: use edit mode component.

Comment 6

[Jason Smith [:jsmith]]

Ok fair enough. Don't think this would be a blocker though.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Arthur,
Edit mode in Downloads app was not properly implemented, as it was not using edit mode Building Block.
Now with gaia-buttons Web component is much easier just replacing the bottom menu than implementing the old edit mode BB.
Adding Wilson for f? as he is more familiar with that component.

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8431382 [details] [review]
patch in github

Looks great Arnau!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8431382 [details] [review]
patch in github

Working perfectly,

thanks Arnau!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8431382 [details] [review]
patch in github

Sorry, just remove Arthur, since this is a Download Manager patch.

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 5dfe4ec36758b5d9aaa241926be9de2d8c4da7d4

Comment 13

[rafael.marquez]

Verified in master(2.0) branch