1017565 - Make style editor media sidebar match devtools themes

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Tim Nguyen :ntim]

Right now, the border-colors don't match. Light theme should be #AAA and dark theme should be #000

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch v1

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8436432 [details] [diff] [review]
Patch v1

Review of attachment 8436432 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/styleeditor.css
@@ +78,4 @@
>  }
>  
>  .theme-light .media-rule-label {
> +  border-bottom-color: #cddae5; /* Grey */  

Where did you get the grey colors from?  Looks like you are looking for something lighter than the splitter color.  I guess we don't really have much here:  https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors.

I've often used splitter with alpha for this effect rgba(170, 170, 170, .5) or something.

Also, there is some extra whitespace at the end of this line

Comment 3

[Tim Nguyen :ntim]

I used the colors from the inspector sidebar.
Should that be changed in another bug ?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #3)
> I used the colors from the inspector sidebar.
> Should that be changed in another bug ?

OK I see that now (theme-separator).  That's fine - just reupload the patch with the trailing whitespace removed and push to try.

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch v2

Comment 6

[Tim Nguyen :ntim]

Try : https://tbpl.mozilla.org/?tree=Try&rev=85fa732898eb

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8437173 [details] [diff] [review]
Patch v2

Review of attachment 8437173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7b49eebb460