Closed Bug 1017565 Opened 8 years ago Closed 8 years ago

Make style editor media sidebar match devtools themes

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: ntim, Assigned: ntim)

Details

Attachments

(1 file, 1 obsolete file)

Right now, the border-colors don't match. Light theme should be #AAA and dark theme should be #000
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #8436432 - Flags: review?(bgrinstead)
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Comment on attachment 8436432 [details] [diff] [review]
Patch v1

Review of attachment 8436432 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/styleeditor.css
@@ +78,4 @@
>  }
>  
>  .theme-light .media-rule-label {
> +  border-bottom-color: #cddae5; /* Grey */  

Where did you get the grey colors from?  Looks like you are looking for something lighter than the splitter color.  I guess we don't really have much here:  https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors.

I've often used splitter with alpha for this effect rgba(170, 170, 170, .5) or something.

Also, there is some extra whitespace at the end of this line
Attachment #8436432 - Flags: review?(bgrinstead)
I used the colors from the inspector sidebar.
Should that be changed in another bug ?
Flags: needinfo?(bgrinstead)
(In reply to Tim Nguyen [:ntim] from comment #3)
> I used the colors from the inspector sidebar.
> Should that be changed in another bug ?

OK I see that now (theme-separator).  That's fine - just reupload the patch with the trailing whitespace removed and push to try.
Flags: needinfo?(bgrinstead)
Attached patch Patch v2Splinter Review
Attachment #8436432 - Attachment is obsolete: true
Attachment #8437173 - Flags: review?(bgrinstead)
Comment on attachment 8437173 [details] [diff] [review]
Patch v2

Review of attachment 8437173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me
Attachment #8437173 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e7b49eebb460
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.