1017571 - Scrolling horizontally results in rendering glitches

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Mark Reid [:mreid]]

Attachment: tab_bar_glitch.png

For the past few nightly builds, I've seen some rendering glitches while scrolling the tab bar.

If I wait, the glitches disappear after a delay of a few seconds.

Configuration:
Firefox 32.0a1 (2014-05-29) on Retina Macbook Pro, Mac OS X 10.9

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I see this too, and it's terrible. I suspect this is more fallout from bug 1012407.

Comment 2

[Mark Reid [:mreid]]

Attachment: horizontal_text_scroll_glitch-compressor.png

Looks like there's a similar thing going on with horizontal scrolling of in-page content too.

Comment 3

[Mark Reid [:mreid]]

I made a quick test page here:
http://people.mozilla.org/~mreid/bug1017571/wide.html

Comment 5

[Andreas Gal :gal]

I can reproduce this.

Comment 6

[Andreas Gal :gal]

Comment 3 I can reproduce. Looks like the 2nd triangle of a quad isn't rendered right.

Comment 7

[Andreas Gal :gal]

I am out for the next 8 hours. Will start looking at this when I am back. Not opposed at all to a backout if that fixes this.

Comment 8

[(no longer active)]

I bet bug 1018172 is also related.

Comment 10

[Mark Reid [:mreid]]

Updated bug summary to reflect that it's horizontal scrolling both of the tab bar and content.

Comment 11

[Andreas Gal :gal]

Could someone please try with https://hg.mozilla.org/mozilla-central/rev/450878674b08 backed out?

Comment 12

[Andreas Gal :gal]

Ok, I can look at this now.

Comment 13

[Andreas Gal :gal]

So this goes away for me if I don't try to draw the quads at once with the int(coords.z) trick.

Comment 14

[Andreas Gal :gal]

Attachment: Only render 1 quad at a time for now.

Comment 15

[Andreas Gal :gal]

Comment on attachment 8431916 [details] [diff] [review]
Only render 1 quad at a time for now.

Temporary band aid until we come up with a more clever trick.

Comment 16

[Andreas Gal :gal]

If this goes green on inbound, can you transplant to central please? This is an active regression.

Comment 17

[Andreas Gal :gal]

Attachment: Better fix: use GL_TRIANGLES instead of GL_TRIANGLE_STRIP

Comment 19

[Andreas Gal :gal]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d092685332ff

Comment 21

[Andreas Gal :gal]

https://hg.mozilla.org/mozilla-central/rev/fc91e69c3473

Comment 23

[Andreas Gal :gal]

This was hitting Linux and ATI drivers as well, according to a comment in bug 1015176. This is good to know. This gives me some confidence that this fix will actually make this work on most GPUs.

Comment 24

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d092685332ff

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I was seeing this on Linux with an Intel GPU (with layers.acceleration.force-enabled).

Comment 28

[Kyle Simpson]

I was seeing this bug on a mid-2013 macbook air with ff-nightly. Just updated to 6/3/2014 build and it's not happening anymore that I can tell.

Comment 29

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marking as verified based on the previous 2 comments.