remove MOZ_NSS_PATCH functionality

RESOLVED FIXED in mozilla32

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla32

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8430876 [details] [diff] [review]
remove MOZ_NSS_PATCH functionality

This stuff seems really dodgy.  If we need to patch NSS, presumably we should
be committing changes to hg so we have a record of what's been done, even if we
have to roll things back later.
(Assignee)

Comment 2

4 years ago
Comment on attachment 8430876 [details] [diff] [review]
remove MOZ_NSS_PATCH functionality

See comment 1 for rationale.
Attachment #8430876 - Flags: review?(mh+mozilla)
See bug 511743 as to why this was added.
Depends on: 511743
(Assignee)

Comment 4

4 years ago
So we have this functionality, but it's currently unused and we've (likely) never used it for going on five years?
ISTR having seen it used.
Comment on attachment 8430876 [details] [diff] [review]
remove MOZ_NSS_PATCH functionality

Review of attachment 8430876 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/build/Makefile.in
@@ +256,1 @@
>  NSS_SRCDIR = $(topsrcdir)

You could remove this variable and replace if with topsrcdir everywhere it's used.
Attachment #8430876 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 7

4 years ago
Since Vlad requested the functionality to be added in bug 511743, perhaps he has suggestions on whether this feature's time has come and gone.  Vlad?
Flags: needinfo?(vladimir)
Sure, nuke away
Flags: needinfo?(vladimir)
https://hg.mozilla.org/mozilla-central/rev/ef6fc5965a4c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
(Assignee)

Updated

4 years ago
Assignee: nobody → nfroyd

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.