Closed Bug 1017680 Opened 6 years ago Closed 6 years ago

Allow ClientTiledThebesLayer to process any 2d translation/scale transform

Categories

(Core :: Graphics: Layers, defect)

32 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

After bug 1016558 is fixed, the BeginPaint code in ClientTiledThebesLayer should be able to deal with any 2d scale or translation transform. We should be able to update the FIXME block to account for this. We might also be able to get rid of the Fennec special-casing there, I haven't thought that through fully.
Attached patch PatchSplinter Review
As far as I can tell this works fine. I made a page with a CSS rotate transform and that seemed to render fine too (in Fennec at least). Probably needs more testing though.
Further testing showed nothing amiss, either on Flame or on Fennec. Try push: https://tbpl.mozilla.org/?tree=Try&rev=7e656c0d68a8
Comment on attachment 8431266 [details] [diff] [review]
Patch

Review of attachment 8431266 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8431266 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/333ad108d63d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.