1017680 - Allow ClientTiledThebesLayer to process any 2d translation/scale transform

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

After bug 1016558 is fixed, the BeginPaint code in ClientTiledThebesLayer should be able to deal with any 2d scale or translation transform. We should be able to update the FIXME block to account for this. We might also be able to get rid of the Fennec special-casing there, I haven't thought that through fully.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

As far as I can tell this works fine. I made a page with a CSS rotate transform and that seemed to render fine too (in Fennec at least). Probably needs more testing though.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Further testing showed nothing amiss, either on Flame or on Fennec. Try push: https://tbpl.mozilla.org/?tree=Try&rev=7e656c0d68a8

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8431266 [details] [diff] [review]
Patch

Review of attachment 8431266 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Try push from comment 2 didn't have B2G emulator stuff so I did another push to cover that: https://tbpl.mozilla.org/?tree=Try&rev=5f65cb3f6bf5

All green, so landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/333ad108d63d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/333ad108d63d