Closed Bug 1017692 Opened 7 years ago Closed 7 years ago

Add more logging to HPACK implementation

Categories

(Core :: Networking: HTTP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: u408661, Assigned: u408661)

Details

(Whiteboard: [spdy])

Attachments

(1 file)

This should (hopefully) make debugging interop issues with HPACK implementations easier.
Attached patch patchSplinter Review
Attachment #8430900 - Flags: review?(mcmanus)
Comment on attachment 8430900 [details] [diff] [review]
patch

Review of attachment 8430900 [details] [diff] [review]:
-----------------------------------------------------------------

awesome. can you change all the log levels here to be explicit or implicit and probably at the same high level (4 or 5?). when not chasing hpack this is mega noise.
Attachment #8430900 - Flags: review?(mcmanus) → review+
Yeah, let's just settle on using the implicit LOG == LOG5 everywhere in hpack. I'll go ahead and fold it into this patch (most of the logs are already the implicit 5 anyway)
https://hg.mozilla.org/mozilla-central/rev/c65c31b6c6b3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.