If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Build breakage due to __sun__ while using sun's compilers on intel

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
16 years ago
13 years ago

People

(Reporter: Neelakanth Nadgir, Assigned: cls)

Tracking

Trunk
x86
Solaris

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

16 years ago
On Solaris/Intel, mozilla fails to build. 

xptc_platforms_unixish_x86.h has

116 #elif defined(__sun__)
117 #define CFRONT_STYLE_THIS_ADJUST
118 119 #else
120 #error "need a platform define if using unixish x86 code"
121 #endif


Sun's intel compiler does not define __sun__, but does define __sun
Since both GCC and Sun define __sun, It would be nice to change the code to
check for __sun. So changing __sun__ to __sun in this particular header 
file will not break GCC. Another workaround is to make configure add 
-D__sun__ to the makefiles if it sees an intel platform, and Sun's forte
compiler, but the first one is better.
Checked in the following change:

-#elif defined(__sun__)
+#elif defined(__sun__) || defined(__sun)
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.