Closed
Bug 1017748
Opened 10 years ago
Closed 10 years ago
Use FxA's OAuth URL for the assertion audience.
Categories
(Firefox OS Graveyard :: FindMyDevice, defect)
Firefox OS Graveyard
FindMyDevice
Tracking
(b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S4 (20june)
People
(Reporter: ggp, Assigned: ggp)
Details
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
vingtetun
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Review |
Our FxA assertion should not be obtained using FMD's API URL as audience, but rather FxA's OAuth URL: https://oauth.dev.lcip.org
Updated•10 years ago
|
Target Milestone: --- → 2.0 S3 (6june)
Comment 1•10 years ago
|
||
Note to self: need to swap to production.
Updated•10 years ago
|
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8437832 -
Flags: review?(21)
Comment 3•10 years ago
|
||
Comment on attachment 8437832 [details] [review]
gaia pull request
Do you need to uplift that to 2.0 ?
Attachment #8437832 -
Flags: review?(21) → review+
Comment 4•10 years ago
|
||
ggp: As long as the URL is stored in a config file, we should be good. There are URLs for dev, stage and prod. I don't know if prod is live yet.
Assignee | ||
Comment 5•10 years ago
|
||
So yes, we do need it uplifted. I'll do the paperwork later today, but unless I'm mistaken we can land now on master.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8437832 [details] [review]
gaia pull request
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1017748
[User impact] if declined: The feature won't work, as this patch is necessary for Firefox Accounts integration.
[Testing completed]: With this patch, the device can successfully use its Firefox Account to register to the Find My Device service
[Risk to taking this patch] (and alternatives if risky): No risk.
[String changes made]: None.
Attachment #8437832 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
Attachment #8437832 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 8•10 years ago
|
||
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•