Closed
Bug 1017852
Opened 11 years ago
Closed 11 years ago
Make the jit and c++ nursery allocation code the same
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
The jit does: *addressOfCurrentEnd < (*addressOfPostion + totalSize)
Nursery::allocate does: if (position + size > end) { /* fail logic */ }
This mismatched check isn't going to cause any problems in practice, but we should still minimize the wtf factor.
|
Assignee | |
Comment 1•11 years ago
|
||
Actually I meant to type: *addressOfCurrentEnd <= (*addressOfPostion + totalSize)
This is still safe though: we will simply bail out one allocation early. This will succeed in C++, come back to the JIT and then immediately bail on the next allocation.
Patch is trivial though so we might as well fix it.
Attachment #8431184 -
Flags: review?(jcoppeard)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8431184 [details] [diff] [review]
make_nursery_full_check_the_same-v0.diff
Review of attachment 8431184 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, let's make these the same.
Attachment #8431184 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•