1017874 - Help button on in-content preferences' initial "General" section has no effect, until you've switched to another section and back

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Edit | Preferences (or visit about:preferences)
 2. Click the yellow help button in lower-right corner.

ACTUAL RESULTS: Nothing.
EXPECTED RESULTS: Some help page should load.


If I click between sections on the left side (e.g. go to "Content" and then back to "General", *then* the help button works. However, until I've switched sections, the button is non-functional.

Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
32.0a1 (2014-05-29)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: initGeneral.patch

Load the "General" pane on init to initialize the correct category for the help button.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8431373 [details] [diff] [review]
initGeneral.patch

Review of attachment 8431373 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/preferences.js
@@ +32,5 @@
>  
>    let categories = document.getElementById("categories");
>    categories.addEventListener("select", event => gotoPref(event.target.value));
> +
> +  gotoPref("paneGeneral");

Now that gotoPref is used here, please mark everything in main.xul hidden="true". This will be consistent with what we do in the other panes such as applications.xul.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: initGeneral.patch

generalPane is now also initially hidden before gotoPref() call.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8431601 [details] [diff] [review]
initGeneral.patch

Review of attachment 8431601 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=d9be1294d176

Comment 6

[Richard Marti (:Paenglab)]

Attachment: patch updated to tip

Unbitrot after landing of bug 1013904.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/096614464990

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/096614464990

Comment 9

[Francesca Ciceri [:madamezou]]

Hi,

I was able to reproduce it on Firefox/32.0 ID:20140530030202 on Debian Sid x86_64, and can confirm is now fixed in latest Nightly Firefox/32.0 ID:20140603030220.

Cheers,
Francesca