Closed
Bug 1017874
Opened 10 years ago
Closed 10 years ago
Help button on in-content preferences' initial "General" section has no effect, until you've switched to another section and back
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 32
Tracking | Status | |
---|---|---|
firefox32 | --- | verified |
People
(Reporter: dholbert, Assigned: Paenglab)
References
()
Details
Attachments
(1 file, 2 obsolete files)
3.74 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Edit | Preferences (or visit about:preferences) 2. Click the yellow help button in lower-right corner. ACTUAL RESULTS: Nothing. EXPECTED RESULTS: Some help page should load. If I click between sections on the left side (e.g. go to "Content" and then back to "General", *then* the help button works. However, until I've switched sections, the button is non-functional. Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 32.0a1 (2014-05-29)
Reporter | ||
Updated•10 years ago
|
Blocks: 1017594
Summary: Help button on in-content preferences window has no effect, until you've switched between sections → Help button on in-content preferences' initial "General" section has no effect, until you've switched to another section and back
Updated•10 years ago
|
Blocks: ship-incontent-prefs
Assignee | ||
Comment 1•10 years ago
|
||
Load the "General" pane on init to initialize the correct category for the help button.
Comment 2•10 years ago
|
||
Comment on attachment 8431373 [details] [diff] [review] initGeneral.patch Review of attachment 8431373 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/preferences/in-content/preferences.js @@ +32,5 @@ > > let categories = document.getElementById("categories"); > categories.addEventListener("select", event => gotoPref(event.target.value)); > + > + gotoPref("paneGeneral"); Now that gotoPref is used here, please mark everything in main.xul hidden="true". This will be consistent with what we do in the other panes such as applications.xul.
Attachment #8431373 -
Flags: review?(jaws) → review-
Assignee | ||
Comment 3•10 years ago
|
||
generalPane is now also initially hidden before gotoPref() call.
Attachment #8431373 -
Attachment is obsolete: true
Attachment #8431601 -
Flags: review?(jaws)
Comment 4•10 years ago
|
||
Comment on attachment 8431601 [details] [diff] [review] initGeneral.patch Review of attachment 8431601 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8431601 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=d9be1294d176
Keywords: checkin-needed
Assignee | ||
Comment 6•10 years ago
|
||
Unbitrot after landing of bug 1013904.
Attachment #8431601 -
Attachment is obsolete: true
Attachment #8431857 -
Flags: review+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/096614464990
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/096614464990
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Comment 9•10 years ago
|
||
Hi, I was able to reproduce it on Firefox/32.0 ID:20140530030202 on Debian Sid x86_64, and can confirm is now fixed in latest Nightly Firefox/32.0 ID:20140603030220. Cheers, Francesca
You need to log in
before you can comment on or make changes to this bug.
Description
•