Closed Bug 1017874 Opened 7 years ago Closed 7 years ago

Help button on in-content preferences' initial "General" section has no effect, until you've switched to another section and back

Categories

(Firefox :: Preferences, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
firefox32 --- verified

People

(Reporter: dholbert, Assigned: Paenglab)

References

()

Details

Attachments

(1 file, 2 obsolete files)

STR:
 1. Edit | Preferences (or visit about:preferences)
 2. Click the yellow help button in lower-right corner.

ACTUAL RESULTS: Nothing.
EXPECTED RESULTS: Some help page should load.


If I click between sections on the left side (e.g. go to "Content" and then back to "General", *then* the help button works. However, until I've switched sections, the button is non-functional.

Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
32.0a1 (2014-05-29)
Blocks: 1017594
Summary: Help button on in-content preferences window has no effect, until you've switched between sections → Help button on in-content preferences' initial "General" section has no effect, until you've switched to another section and back
Attached patch initGeneral.patch (obsolete) — Splinter Review
Load the "General" pane on init to initialize the correct category for the help button.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8431373 - Flags: review?(jaws)
Comment on attachment 8431373 [details] [diff] [review]
initGeneral.patch

Review of attachment 8431373 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/preferences.js
@@ +32,5 @@
>  
>    let categories = document.getElementById("categories");
>    categories.addEventListener("select", event => gotoPref(event.target.value));
> +
> +  gotoPref("paneGeneral");

Now that gotoPref is used here, please mark everything in main.xul hidden="true". This will be consistent with what we do in the other panes such as applications.xul.
Attachment #8431373 - Flags: review?(jaws) → review-
Attached patch initGeneral.patch (obsolete) — Splinter Review
generalPane is now also initially hidden before gotoPref() call.
Attachment #8431373 - Attachment is obsolete: true
Attachment #8431601 - Flags: review?(jaws)
Comment on attachment 8431601 [details] [diff] [review]
initGeneral.patch

Review of attachment 8431601 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8431601 - Flags: review?(jaws) → review+
Unbitrot after landing of bug 1013904.
Attachment #8431601 - Attachment is obsolete: true
Attachment #8431857 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/096614464990
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Hi,

I was able to reproduce it on Firefox/32.0 ID:20140530030202 on Debian Sid x86_64, and can confirm is now fixed in latest Nightly Firefox/32.0 ID:20140603030220.

Cheers,
Francesca
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20140604]
You need to log in before you can comment on or make changes to this bug.