Closed Bug 1017909 Opened 10 years ago Closed 10 years ago

refactor credentials into separate object

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: dmosedale, Unassigned)

References

Details

Right now, Client.js is handling enough state that it's starting to feel a bit fragile, and the Hawk credentials changes put this a bit over the edge.

We might want a request helper class like (or perhaps even shared with) <https://github.com/ferjm/msisdn-verifier-client/blob/master/js/client_request_helper.js>.  We might also just want a mixin.

But the code as it stands is too hard to test well.
The credentials code got moved back into shared code in gecko land via the mozLoop api, hence we no longer need to worry about these.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.