1017932 - Document() constructor should return Document object (not XMLDocument)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Arkadiusz Michalski (Spirit)]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

Per DOM:
http://dom.spec.whatwg.org/#dom-document
"Unlike createDocument() this constructor does not return an XMLDocument object, but a document (Document object)."

Firefox return XMLDocument with acces to load method. Other browsers don't support this constructor so there is still much space for possible change.

Comment 1

[Boris Zbarsky [:bzbarsky]]

There are all sorts of places where we return XMLDocument where specs are sort of trying to return Document (e.g. DOMParser).

I guess it would be pretty simple to fix this particular one, assuming the web can deal with actual Document instances.  Right now we never return those from anywhere.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't expose the XMLDocument bits on the return value of new Document

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 8431286 [details] [diff] [review]
Don't expose the XMLDocument bits on the return value of new Document

Review of attachment 8431286 [details] [diff] [review]:
-----------------------------------------------------------------

Wish we could just instantiate nsDocument :-(.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15aa216cebf9