1017962 - Decouple the control of screen backlight and button/keyboard backlight at Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sean Lin [:seanlin] (inactive from Mar 2016)]

In bug 911242, we've decoupled the control of button/keyboard backlight from screen backlight in MozPowerManager. So they are no longer controlled in align with each other. A follow-up fix may be necessary at Gaia to better cover the changes.

Comment 1

[Marco Chen [:mchen]]

After discussing with Tim, in this bug we may still let backlight dis/enabling of screen couple to button/keyboard on the gaia side. This is in order to unblock the landing of gecko patch.

Then involing UX design to finish complete gaia work.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Evelyn, landing of bug 911242 without Gaia part here have unfortunately caused regression. Anyone in your team can take over the work from Sean? If not I will ask my team to take this.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Next release would need this or we would have to backout the Gecko part first.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Without any fancy UX, the Gaia patch is actually pretty trivial, given the WebIDL described here:

https://hg.mozilla.org/mozilla-central/diff/3dd59dda51fc/dom/webidl/MozPowerManager.webidl

Comment 6

[Marco Chen [:mchen]]

To give the reason for splitting the backlight of screen and keypad:
  Referring to the experience from Helix project, the partner already modified this idea into their local branch. Partner would like to reduce the power consumption from disabling the keypad backlight in a short period not following the screen backlight. From their UX point of view, the keypad backlight is no necessary to keep that longer as screen's.

From eng point of view, to extend the flexibility of platform capability is our goal then Gaia can follow the different UX to design the relationship between screen and keypad's backlight.

If UX doesn't have any opinion then the easy way is to enable/disable screen and keypad's backlight in the same timing. If partner has different thought then they can still customize easily because web api is there already.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

I made a patch to synchronize key backlight behavior with screen. Partner could always customize this by removing the patch and doing their own customization.

Hi Tim,
Could you help to review the patch? Thanks

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8622342 [details] [review]
pull request

Woot and thanks!

Comment 9

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-try result:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=895809e35efaf3f8cde1d7ed235e3a58f3951772

Landed in master
https://github.com/mozilla-b2g/gaia/commit/6f445de0d4935e6809d1d4a3833eab7af56e7613

Comment 10

[u535950]

Hello,

Is it possible to also apply this patch on 2.2 and 2.1 branches ?