1018032 - ringtone name doesn't change while the language change in sound page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[yang.zhao]

Attachment: screenshot of the phone

STR:
1,Assume current language is en-US
2,Go to setting->go to sound->Ringer,set a ringtone such as "Classic courier" and save
3,kill the settings app by long press the HOME button and slide the settings up.
4,settings->language->change it to hi-IN ,click ok,then change it to en-US,click ok,then again change it to hi-IN.
5,enter sound,you'll find the ringtone name displays in en-US.

Comment 1

[yang.zhao]

Select ringtone is in ringtone app.The name was stored as a string without a l10n-id information in sound.js in settings app.Maybe both of the settings and ringtone should change for this issue.
Both of v1.3t and v1.4 are all have this issue.

Comment 2

[Jim Porter (:squib)]

Fixed by bug 960329.

Comment 3

[yang.zhao]

(In reply to Jim Porter (:squib) from comment #2)
> Fixed by bug 960329.
Hi,Jim
  Does bug 960329 already land on v1.3t and v1.4? And I don't think this issue is the same with bug 960329,have you ever tried the STR in comment 0?

Comment 4

[Jim Porter (:squib)]

(In reply to yang.zhao from comment #3)
> (In reply to Jim Porter (:squib) from comment #2)
> > Fixed by bug 960329.
> Hi,Jim
>   Does bug 960329 already land on v1.3t and v1.4? And I don't think this
> issue is the same with bug 960329,have you ever tried the STR in comment 0?

Bug 960329 is only in 2.0+, but I *have* tested the STR in comment 0 and it works as expected in 2.0 (well, 2.1, but nothing has changed lately). I would push pretty hard against fixing this in 1.3/1.4, since this is a minor edge case and would be a relatively complex change.

Comment 5

[yang.zhao]

(In reply to Jim Porter (:squib) from comment #4)
> (In reply to yang.zhao from comment #3)
> > (In reply to Jim Porter (:squib) from comment #2)
> > > Fixed by bug 960329.
> > Hi,Jim
> >   Does bug 960329 already land on v1.3t and v1.4? And I don't think this
> > issue is the same with bug 960329,have you ever tried the STR in comment 0?
> 
> Bug 960329 is only in 2.0+, but I *have* tested the STR in comment 0 and it
> works as expected in 2.0 (well, 2.1, but nothing has changed lately). I
> would push pretty hard against fixing this in 1.3/1.4, since this is a minor
> edge case and would be a relatively complex change.
Thank you for your reply! I found bug 960329 modified so many files, since this is a minor edge, I agree with you.^_^