1018039 - Use --enable-dmd on debug desktop tinderbox builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nicholas Nethercote [inactive]]

I'd like to have compile coverage for DMD on TBPL. (Just this morning I fixed some Windows-only bustage: bug 1017911.)

I propose adding --enable-dmd for debug tinderbox builds.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Enable DMD on TBPL debug builds

Bug 948621 explains why the --enable-profiling is required on Windows.

The nsJSEnvironment.cpp change is required so we don't pollute the global
namespace, because that causes test errors. We can still trigger DMD from
about:memory, which is now the preferred way to do it.

Try server looks happy, even for Win64:
https://tbpl.mozilla.org/?tree=Try&rev=ade5317e634f

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8431346 [details] [diff] [review]
Enable DMD on TBPL debug builds

Review of attachment 8431346 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe at some point we'd want it enabled by default for --enable-debug builds (that is, even local ones)

Comment 3

[Nicholas Nethercote [inactive]]

> Maybe at some point we'd want it enabled by default for --enable-debug
> builds (that is, even local ones)

Maybe, though in practice using DMD in debug builds is... well, it's not something I do often.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d743e0af95e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d743e0af95e