Closed Bug 1018039 Opened 5 years ago Closed 5 years ago

Use --enable-dmd on debug desktop tinderbox builds

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

I'd like to have compile coverage for DMD on TBPL. (Just this morning I fixed some Windows-only bustage: bug 1017911.)

I propose adding --enable-dmd for debug tinderbox builds.
Summary: Don't use --enable-trace-malloc on debug desktop tinderbox builds → Use --enable-dmd on debug desktop tinderbox builds
Bug 948621 explains why the --enable-profiling is required on Windows.

The nsJSEnvironment.cpp change is required so we don't pollute the global
namespace, because that causes test errors. We can still trigger DMD from
about:memory, which is now the preferred way to do it.

Try server looks happy, even for Win64:
https://tbpl.mozilla.org/?tree=Try&rev=ade5317e634f
Attachment #8431346 - Flags: review?(mh+mozilla)
Comment on attachment 8431346 [details] [diff] [review]
Enable DMD on TBPL debug builds

Review of attachment 8431346 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe at some point we'd want it enabled by default for --enable-debug builds (that is, even local ones)
Attachment #8431346 - Flags: review?(mh+mozilla) → review+
> Maybe at some point we'd want it enabled by default for --enable-debug
> builds (that is, even local ones)

Maybe, though in practice using DMD in debug builds is... well, it's not something I do often.
https://hg.mozilla.org/mozilla-central/rev/7d743e0af95e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.