1018041 - pkix_ocsp_request_tests.obj : error LNK2001: unresolved external symbol _CERT_NameTemplate when building on Windows with GTest enabled

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

> return SEC_ASN1EncodeItem(arena.get(), nullptr, certName.get(),
>                           CERT_NameTemplate);

s/CERT_NameTemplate/SEC_ASN1_GET(CERT_NameTemplate)/

Reason: At one point in time, if not currently, Windows DLLs don't export data (as opposed to symbols) correctly, so NSS exports functions for getting at these templates on Windows.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-CERT_NameTemplate-reference.patch

Comment 2

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8431380 [details] [diff] [review]
fix-CERT_NameTemplate-reference.patch

Review of attachment 8431380 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. It would be nice to have a comment explaining the issue.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to David Keeler (:keeler) [use needinfo?] from comment #2)
> Looks good to me. It would be nice to have a comment explaining the issue.

Thanks for the review!

I didn't add the comment because I don't think that comment will really help anybody since they wont encounter the issue in this particular code ever again. It is just one of those things we have to learn when writing new code.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69d7eaad0a50

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/69d7eaad0a50