Closed Bug 1018041 Opened 6 years ago Closed 6 years ago

pkix_ocsp_request_tests.obj : error LNK2001: unresolved external symbol _CERT_NameTemplate when building on Windows with GTest enabled

Categories

(Core :: Security: PSM, defect)

All
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

> return SEC_ASN1EncodeItem(arena.get(), nullptr, certName.get(),
>                           CERT_NameTemplate);

s/CERT_NameTemplate/SEC_ASN1_GET(CERT_NameTemplate)/

Reason: At one point in time, if not currently, Windows DLLs don't export data (as opposed to symbols) correctly, so NSS exports functions for getting at these templates on Windows.
Assignee: nobody → brian
Status: NEW → ASSIGNED
Attachment #8431380 - Flags: review?(dkeeler)
Comment on attachment 8431380 [details] [diff] [review]
fix-CERT_NameTemplate-reference.patch

Review of attachment 8431380 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. It would be nice to have a comment explaining the issue.
Attachment #8431380 - Flags: review?(dkeeler) → review+
(In reply to David Keeler (:keeler) [use needinfo?] from comment #2)
> Looks good to me. It would be nice to have a comment explaining the issue.

Thanks for the review!

I didn't add the comment because I don't think that comment will really help anybody since they wont encounter the issue in this particular code ever again. It is just one of those things we have to learn when writing new code.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69d7eaad0a50
https://hg.mozilla.org/mozilla-central/rev/69d7eaad0a50
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.