1018042 - [l10n] Plural form for Application storage available space is sometimes wrong

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Théo Chevalier]

Attachment: Screenshot Flame master, French

When there is 2GB available for App storage, the plural form is wrong.

On the screenshot you can see "2 Go disponible".

But if we take a look at the French localization, we can see that when {{size}} equals 2, it should display "2 Go disponibles" https://hg.mozilla.org/gaia-l10n/fr/file/44205165ad6c/apps/settings/settings.properties#l673

You can also notice that for Media storage, the plural form is working as expected: "3.8 Go disponibles".

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/storage.js#L178 The variable freespace here probably contains numeric format that l10n.js doesn't appreciate.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Keon, Italian

That's strange: on Keon I get "1.5 disponibili", with the right plural form.

One first step would probably be to display or log that value on a flame, to see what is passed to l10n.js

Comment 2

[Francesco Lodolo [:flod]]

Note: could be related to the issue we discovered in bug 1022445.
"2", if passed a string instead of a number, use the form for "[one]" instead of "[other]".

Comment 3

[Francesco Lodolo [:flod]]

Looks like size is passed as a string in the helper function
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/utils.js#L143

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 5

[Francesco Lodolo [:flod]]

Attachment: French screenshot on patched flame/master

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8438362 [details] [review]
Pull request on Github

Thanks Francesco, nice catch !

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Here comes the code why this bug would happen: 

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/l10n.js#L837

Comment 8

[Francesco Lodolo [:flod]]

I think we need this also on 2.0 at this point, setting flag + keyword for checkin.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/eb5b999efaad112f2dbfcf6122bade2ffc8fb361

Comment 10

[Francesco Lodolo [:flod]]

Verified on last Flame master build. French now says "2 Go disponibles".

Build ID: 20140612160203

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Francesco :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/d5b60532d493207d2f1670a2dd4f19d9498b5262