Closed
Bug 1018069
Opened 12 years ago
Closed 12 years ago
<tree>'s _move*() should call preventDefault() themselves
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
7.54 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
Spinning out from bug 777832 comment 7:
> neil@parkwaycc.co.uk 2014-05-16 03:13:29 PDT
>
> Comment on attachment 8421105 [details] [diff] [review] [diff] [review]
> Patch
>
> Wouldn't it have been easier to move the preventDefault calls into the _move* functions?
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8433113 -
Flags: review?(enndeakin)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8433113 [details] [diff] [review]
Patch
I don't think the comments are needed in every case.
Attachment #8433113 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Thank you. I removed the whole comments.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7652c6ab1d36
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•