Closed Bug 1018156 Opened 6 years ago Closed 2 years ago

charset annotation should not be

Categories

(Toolkit :: Places, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mak, Unassigned)

References

(Blocks 1 open bug)

Details

We are storing the charset annotation for every bookmark, while we only need it when the user enforces a charset from the menu or for keywords.

The latter case is a little bit problematic, the right way to create a keyword is to right click an input field and choose Add keyword for this search, but we also allow to define a keyword in the Properties dialog. One may then create a bookmark first and set a keyword later, and we'd not have the charset at that point...

The other problem is that due to this bug we can't distinguish user-set charsets from the ones we automatically set with bookmarks, to cleanup this mess we have to remove all of them causing some dataloss...
Over IRC we figured the right thing to do would be to load the page in a hidden iframe if the keyword is set the "wrong" way. That's not "a lot" of work, but it's "enough". The upgrade story is also an "enough", and so is the maintenance part. All in all, that's a lot of work for fixing a "theoretical" issue. So, as much as I want this fixed, I don't think we're going to do anything about this in the near future.
to clarify, the win here would be something around 10-100KB of database space.
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Summary: charset annotation is set for any bookmark → charset annotation should not be
You need to log in before you can comment on or make changes to this bug.