Closed
Bug 1018162
Opened 10 years ago
Closed 10 years ago
toolbox.dtd - showUserAgentStyles entities are in the middle of defaultColorUnit entities
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
pbro
:
review+
flod
:
feedback+
|
Details | Diff | Splinter Review |
As seen here: https://hg.mozilla.org/mozilla-central/diff/40046039330c/browser/locales/en-US/chrome/browser/devtools/toolbox.dtd. These entities should not split up the other group
|
Assignee | |
Comment 1•10 years ago
|
||
Patrick, this just changes the ordering of the entities in toolbox.dtd. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=b48dd95ba01c Francesco, changing the ordering of entities in this file isn't going to cause any problems, is it?
Attachment #8431539 -
Flags: review?(pbrosset)
Attachment #8431539 -
Flags: feedback?(francesco.lodolo)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8431539 [details] [diff] [review] options-entities.patch Review of attachment 8431539 [details] [diff] [review]: ----------------------------------------------------------------- No, moving the string inside the file doesn't affect localization at all.
Attachment #8431539 -
Flags: feedback?(francesco.lodolo) → feedback+
|
||
Updated•10 years ago
|
Attachment #8431539 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/32d85748426d
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32d85748426d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•