1018207 - Wait for loading screen icon in camera tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

The test is failing!

Not sure if the test is failing because it's missing a test patch from master or whether the apps are different. Needs some investigation :)



test_camera_flash_modes (test_camera_flash_modes.TestCameraFlashModes) ... FAIL

======================================================================
FAIL: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zac/.virtualenvs/gaiatest_v1.4/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/camera/test_camera_flash_modes.py", line 26, in test_camera_flash_modes
    self.assertEqual(self.camera.current_flash_mode, 'on')
TEST-UNEXPECTED-FAIL | test_camera_flash_modes.py test_camera_flash_modes.TestCameraFlashModes.test_camera_flash_modes | AssertionError: None != 'on'
----------------------------------------------------------------------
Ran 1 test in 30.332s

Comment 1

[[:AndreiH]]

I don't know how this is passing on master because the change flash button is disabled at first, it is displayed but disabled, until the loader finishes.

Comment 2

[Zac C (:zac)]

Sounds like we need to fix up the master test too?

Comment 3

[[:AndreiH]]

just flashed my phone with master, and it seems that on master the flash button is not disabled until the camera loader disappears

Comment 4

[[:AndreiH]]

I am working to find a suitable wait for this, we already have the self.wait_for_capture_ready() method in the launch, but there are other elements that are not loaded/enabled at the same time as capture is ready.

This would be a good fix for master also.

Comment 5

[[:AndreiH]]

I think we can help ourselves by using this:
https://github.com/mozilla-b2g/gaia/commit/e7da079f399dd8780c85f695405cd8bc9f47fca8

Also for master.

Comment 6

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/19928

Master will benefit from this also

Comment 7

[[:AndreiH]]

Attachment: v1.4 PR https://github.com/mozilla-b2g/gaia/pull/19929

Comment 8

[Zac C (:zac)]

Comment on attachment 8433210 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19928

r+

Comment 9

[Viorela Ioia [:viorela]]

Comment on attachment 8433214 [details] [review]
v1.4 PR https://github.com/mozilla-b2g/gaia/pull/19929

r+

Comment 10

[Florin Strugariu [:Bebe]]

Master: https://github.com/mozilla-b2g/gaia/commit/0dc730a71fdd83563a866b5abf3988e4671a9564

Comment 11

[[:AndreiH]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/01aca16421e37c1156e10d93a12a592a5af5946d