1018233 - Missing </li> in apps/settings/elements/developer.html

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

With the 11b patch from bug 998025, we added a list item, but without the missing closing tag.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Add the closing list item tag

I'm probably requesting the Gaia review the wrong way.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8431620 [details] [diff] [review]
Add the closing list item tag

Looks good to me :)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails, needinfo? please) from comment #2)
> Comment on attachment 8431620 [details] [diff] [review]
> Add the closing list item tag
> 
> Looks good to me :)

Milan can you submit a PR so I can merged it ?

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, I think I just did it, but it's my first PR with Gaia, so I may have missed a step somewhere.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, no point in this typo sitting in developer.html since May.  Botond or Vivien, can one of you just land this?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It's easier if you could just ni one of the Settings app owners.

Comment 7

[Botond Ballo [:botond]]

For reference, the pull request mentioned in comment 4 is here:

https://github.com/mozilla-b2g/gaia/pull/19958

Someone with Gaia commit privileges needs to actually merge it.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/ffe2394f725b88b9c73c6cb02511fdcae5f632b7

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you for fixing the typo!