1018237 - An option to link to webmaker.org and immediately start the login process

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Adam Lofting (:adamlofting)]

For Maker Party we are going to be testing landing pages that are hosted externally (Using Unbounce). The call to action on many of these landing pages will be a button that says something like:

* Login / Create an Account / Join Webmaker / Etc

When a user clicks this link, it needs to go to a place that starts that login process on webmaker, and includes minimal distractions. The end result should be that clicking the CTA button on the landing page an the equivalent UX to clicking the "Join us" button on the webmaker homepage.

Perhaps this could be implemented as a hidden page at webmaker.org/join (for example) that has very minimal content and on page load triggers the login event as though login was clicked. (This hidden page would only be for use with these kind of static externally hosted CTAs).

Comment 1

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/930

Comment 2

[Chris DeCairos (:cade)]

Comment on attachment 8469088 [details] [review]
https://github.com/mozilla/webmaker.org/pull/930

one small thing to change, also, you need to run grunt clean to get the tests passing. R+ with those fixes.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/a2c42569a5ea9effc08602494f3e34484129ad85
Bug 1018237 - An option to link to webmaker.org and immediately start the login process

https://github.com/mozilla/webmaker.org/commit/e6a73a37f2fa38d98b11d21e2cf0847d31284d45
Merge pull request #930 from gesa/1018237/login-plaster

Fixes Bug 1018237 - An option to link to webmaker.org and immediately start the login process

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/20a8dfe661a0815f0ae046721ecaee452ee6e523
Revert " Bug 1018237 - An option to link to webmaker.org and immediately start the login process"

This reverts commit a2c42569a5ea9effc08602494f3e34484129ad85.

Comment 5

[Chris DeCairos (:cade)]

Had to back this out because I totally missed the change to the route handler:

https://github.com/mozilla/webmaker.org/commit/20a8dfe661a0815f0ae046721ecaee452ee6e523#diff-0364f57fbff2fabbe941ed20c328ef1aL339

Comment 6

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/931

Should fix the problem you had to back out for me earlier today, sorry about that.

Comment 7

[Chris DeCairos (:cade)]

Comment on attachment 8471311 [details] [review]
https://github.com/mozilla/webmaker.org/pull/931

R+ with a small modification to the express route definition.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/d59771e816a435e6df99cd73e0d09192cb87bb79
Bug 1018237 - An option to link to webmaker.org and immediately start the login process

https://github.com/mozilla/webmaker.org/commit/705517abfdfdfab97553c426a02f05ef05d32a57
Merge pull request #931 from gesa/1018237/login-plaster

Fixes Bug 1018237 - An option to link to webmaker.org and immediately start the login process