Closed Bug 1018257 Opened 10 years ago Closed 10 years ago

Remove metro UI from the localization tasks for Firefox

Categories

(Firefox for Metro Graveyard :: Build Config, defect)

Product:
Firefox for Metro Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 32

People

(Reporter: Pike, Assigned: Pike)

Details

Attachments

(1 file, 1 obsolete file)

now both l10n.ini and filter.py
1.71 KB, patch
Gavin
: review+
flod
: feedback+
Details | Diff | Splinter Review 
Given we're not shipping metro fx, and don't intend to do soon, let's remove it from the files that we're exposing to Firefox localizers.

We should do this at least on central and aurora. I don't think it's worth doing on beta at this point.
r? on gavin, as he said this should be a good first step.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #8431628 - Flags: review?(gavin.sharp)
Comment on attachment 8431628 [details] [diff] [review]
drop browser/metro from Firefox localizations

Review of attachment 8431628 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to patch filter.py and remove tracks of browser/metro
http://hg.mozilla.org/mozilla-central/file/2208a2ed9745/browser/locales/filter.py
Attachment #8431628 - Flags: feedback-
flod, is this to your liking? (Thanks for catching this earlier)
Attachment #8431628 - Attachment is obsolete: true
Attachment #8431628 - Flags: review?(gavin.sharp)
Attachment #8431633 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8431633 [details] [diff] [review]
now both l10n.ini and filter.py

Review of attachment 8431633 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8431633 - Flags: feedback?(francesco.lodolo) → feedback+
Comment on attachment 8431633 [details] [diff] [review]
now both l10n.ini and filter.py

Over to real review from gavin then.
Attachment #8431633 - Flags: review?(gavin.sharp)
Comment on attachment 8431633 [details] [diff] [review]
now both l10n.ini and filter.py

I don't think this needs "real review" from me (aside perhaps from the policy decision), Francesco can obviously do a better job than I can :)
Attachment #8431633 - Flags: review?(gavin.sharp) → review+
Thanks. Flagging for landing on central.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1fcd38e5b855
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: