1018308 - [NFC] NDEF_FORMATABLE handling in NfcManager should be fixed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

After consulting with Dimi, Garner and Sid we came to conclusion that NDEF_FORMATABLE tech type is not properly handled in NfcManager. Currently NfcManager tries to connect to the tag and then calls readNDEF on it. This is wrong as connect is currently a noop. Even if it would be working, performing readNDEF would fail on the NDEF_FORMATBLE tech type as it does not contain any NDEF records. It might contain some proprietary data though. 

NDEF_FORMATABLE should be handled likewise as other unsupported tags. So it should trigger an 'nfc-tag-discovered' MozActivity.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1018308.txt

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8434196 [details] [review]
pull-request-1018308.txt

If I understand it correctly, what we do in this patch is to delegate the handler of NDEF_FORMATABLE to others, just like the unknown tags. So the patch deleted the handler in the code, and forward it with some extra information.

It looks good on me. I only one concern is that if it's possible to write down the specific switching case instead of falling back to the default section.

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Yes, you understand correctly. I'll wait for Bug 1017572 to be merged and than rebase and add NDEF_FORMATABLE case for readability as you suggested. Thank you for the review.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/60a037865812fd20f8271feddadec99977d58bf8