1018316 - Localize Profile

Status: RESOLVED FIXED

(Webmaker Graveyard :: Profile, defect)

Description

[Gavin Suntop [:gvn]]

Localize our new Profile app.

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker-profile-2/pull/45

Let's file another bug to wrap all the string with the i18n filter and add them to the json file.

This patch should only allow us to move forward and able to localize any new string that's going to be implemented.

Comment 2

[Gavin Suntop [:gvn]]

Comment on attachment 8436258 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/45

Can you localize at least 1 string so we can ensure this is working properly?

Also left some notes on GH.

Comment 3

[Ali Al Dallal [:alicoding]]

Comment on attachment 8436258 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/45

Done :)

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* Status?

Comment 5

[Gavin Suntop [:gvn]]

I need to finish reviewing this. Hope to do that early this week.

Comment 6

[Gavin Suntop [:gvn]]

Comment on attachment 8436258 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/45

I'm still not seeing any of the test strings in here: https://github.com/alicoding/webmaker-profile-2/blob/bug1018316/locale/en_US/profile.json

This is the result:
https://www.dropbox.com/s/grzw70rfrf80ymr/Screenshot%202014-06-18%2009.45.12.png

Comment 7

[Ali Al Dallal [:alicoding]]

Teaching Resources, Makes and Likes? those are all localized? :)

Comment 8

[Gavin Suntop [:gvn]]

https://github.com/alicoding/webmaker-profile-2/blob/bug1018316/app/index.html#L105

Those 3 strings are still hard coded. The words Badges and Events haven't been added to the localization JSON, which is currently empty.

Comment 9

[Gavin Suntop [:gvn]]

Can you rebase?

Comment 10

[Ali Al Dallal [:alicoding]]

Done :gvn :)

Comment 11

[Gavin Suntop [:gvn]]

Comment on attachment 8436258 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/45

Ok, just a couple little tweaks noted on GH, then feel free to land! :)

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-profile-2

https://github.com/mozilla/webmaker-profile-2/commit/ed8cd675676ce3ef9e11b0d84cf52cf913403d85
bug1018316 - localize profile