1018335 - [B2G][Flame] Keyboard is visible when resume from sleep

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Video.ogg

Description:
-If the device is locked while the sms app is open with text entered in the message field, when the user unlocks the device the message field will have disappeared completely rather than showing the message field at the bottom of the screen as it normally does.  The user will have to tap the blank white screen in order to regain control of the keyboard.

-If the user has the sms app open with text entered in the message field and taps the home button, then returns to the sms app, the keyboard will take an abnormally long time to reappear and will show a blank area with the homescreen visible.

-Also displaying the issue described in bug 1015431, comment 11.

Repro Steps:
1) Updated Flame to BuildID: 20140530040207
2) Open the sms and enter text in to the message field
3) Lock the device
4) Unlock the device
5) Tap the home button
6) Reenter the sms app

Actual:
Keyboard will disappear completely or show a large lag in reopening.

Expected:
Keyboard and message entry field always opens in a timely and pretty fashion with the message field being displayed at the bottom of the screen when not in use.

Environmental Variables:
Device: Flame v2.0 MOZ ril
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
Link to failed test case:
See attached: Video, logcat

Comment 1

[Rachel Pribble [:rpribble]]

Should be noted that after the user locks then unlocks the device and encounters the disappearing message field issue, the word suggestion feature no longer appears or functions.

--------------------------------------------------

This issue does not repro on the Flame v1.4 MOZ ril.

Environmental Variables:
Device: Flame v1.4 MOZ ril
BuildID: 20140530000202
Gaia: fe612fd21389193a8e593aa718831602e5086a62
Gecko: 25011f9a8f26
Version: 30.0
Firmware Version: v1.2-device.cfg

SMS app functions as expected.

Comment 2

[Rachel Pribble [:rpribble]]

This issue does occur on the Buri v2.0 MOZ ril.

Environmental Variables:
Device: Buri v2.0 MOZ ril
BuildID: 20140529040201
Gaia: 4142df90c71abdc1e3a87cd37dff1a22d5e38b34
Gecko: 1e712b724d17
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Keyboard will disappear completely or show a large lag in reopening after locking the device, and the word suggestion feature will stop functioning.

Comment 3

[William Hsu [:whsu]]

Hi, all,

I think here have two bugs, and caused by different components.
The first one caused by lockscreen refactor, and the second one caused by keyboard refactor.
I suggest to use different tickets to trace problems.

Hi, Greg,

As I known, lockscreen refactor cause system lag, right?
Have we filed the bug? Thanks!

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

I don't think it's a bug caused by LockScreen 'refactor', because the real 'refactor' patch haven't been landed. There are lots of regressions these days, even though I didn't land any patch of LockScreen these days, because I'm totally stuck at the randomly failed Marionette tests at the as-app bug. So, I think it would be better if we can do bisect to make sure which patch cause this bug.

And please understand that the LockScreen would not only be affected by its own patches. System patches would affect it, too. At least one of the bugs I've read these days is affected by some system patch (since it happened after some Haida supporting patches got landed).

Comment 5

[William Hsu [:whsu]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #4)
> I don't think it's a bug caused by LockScreen 'refactor', because the real
> 'refactor' patch haven't been landed. There are lots of regressions these
> days, even though I didn't land any patch of LockScreen these days, because
> I'm totally stuck at the randomly failed Marionette tests at the as-app bug.
> So, I think it would be better if we can do bisect to make sure which patch
> cause this bug.
> 
> And please understand that the LockScreen would not only be affected by its
> own patches. System patches would affect it, too. At least one of the bugs
> I've read these days is affected by some system patch (since it happened
> after some Haida supporting patches got landed).

Thanks Greg! Helpful information. :)

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

I think it's the same performance bug. See: Bug 1018592.

Comment 7

[howie [:howie]]

there are 3 bugs in this video, this bug is used to track 1st issue, 2nd bug is tracked with bug#1018592, 3rd is bug#1018245

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to howie [:howie] from comment #7)
> there are 3 bugs in this video, this bug is used to track 1st issue, 2nd bug
> is tracked with bug#1018592, 3rd is bug#1018245

Update summary and component for the purpose.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am going to submit a simple patch to hide the keyboard when lock screen locks.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Need QA to verify if 1.4 is affected too.

Comment 11

[Duane Dixon [:ddixon]]

Issue DOES occur in latest 1.4 Flame build. 

Environmental Variables:
Device: Flame 1.4
Build ID: 20140605034248
Gaia: 1f238df7ac68a73a4ceb27391a204c800f38ab1c
Gecko: 6feb759c8bd8
Version: 30.0 (1.4) MOZ
Firmware Version: v10G-2


Issue DOES occur in latest 1.4 Buri build. 

Environmental Variables:
Device: Buri 1.4
Build ID: 20140605072417
Gaia: 183efb374be1bcbf92f1fb3d0212a68b564a6d3e
Gecko: 5bb3061a80a6
Version: 30.0 (1.4) MOZ
Firmware Version: v1.2device.cfg

Comment 12

[Jason Smith [:jsmith]]

What about 1.3?

Comment 13

[Duane Dixon [:ddixon]]

Issue DOES NOT occur in Flame 1.3 base image. 

Issue DOES NOT in earliest nor the latest 1.3 Buri build.

Environmental Variables:
Device: Buri 1.3
Build ID: 20140502004836
Gaia: 667539f1ed4becc45b182a5f1046221d3eeb9e7c
Gecko: 084f8c2adae5
Version: 28.0 (1.3) MOZ
Firmware Version: v1.2device.cfg

Comment 14

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#20121

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8435549 [details] [review]
mozilla-b2g:master PR#20121

This looks like a reasonable approach to tackle this annoying issue.
So, giving r+ here.

However, for 2.0+, I was wondering if we could do something in lockscreen component (app) so that it won't get the focus, so that the keyboard won't be  dismissed.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/deed49c593db32a357a01dbfae57c9b3d419217a

Again, I am not sure if this merge will reach v2.0 branch. leave-open for now until I figure out that (and maybe correct the flags).

Comment 18

[William Hsu [:whsu]]

I cannot reproduce this bug on V2.0 but it still can be reproduced on latest V1.4.
Need to uplift this patch into V1.4 branch.
Thanks.

* Build information: (V1.4)
 - Gaia     765438e65bc23bbda6c82b4093edcd70eb58e8ad
 - Gecko    https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/d17ad4e49b34
 - BuildID  20140611160200
 - Version   30.0
 => Still can be reproduced

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v1.4 uplift.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.4: https://github.com/mozilla-b2g/gaia/commit/fe6d6836601d39341bf3f431d1efb2e2b80ba899

Comment 21

[William Hsu [:whsu]]

There was something wrong on V1.4.
I still can reproduce this bug on latest V1.4 build after the patch was landed.
- fe6d6836601d39341bf3f431d1efb2e2b80ba899

* Build information:
 - Gaia      3bdd037ec1a11abebe16a5d7f6ff0d863e80bc07
 - Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/523491fa3339
 - BuildID   20140618000203
 - Version   30.0
 -> Result: Can be reproduced

Attach the demo video. (WP_20140618_016.mp4)

Comment 22

[William Hsu [:whsu]]

Attachment: WP_20140618_016.mp4

Comment 23

[Jason Smith [:jsmith]]

William - Can you file a followup bug for the issue?

Comment 24

[William Hsu [:whsu]]

I submitted the other bug to trace remaining work. Bug 1027082.
Thanks!

Comment 25

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141208.035628
FW-Date         Mon Dec  8 03:56:38 EST 2014
Bootloader      L1TC00011880

Flame v2.1 version:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880