Closed
Bug 1018364
Opened 11 years ago
Closed 11 years ago
Orientation locked while resuming device
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 unaffected, b2g-v2.1 unaffected)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
b2g-v2.0 | --- | unaffected |
b2g-v2.1 | --- | unaffected |
People
(Reporter: bhargavg1, Assigned: gweng)
References
()
Details
(Keywords: regression, Whiteboard: [caf priority: p3][CR 673422])
Attachments
(2 files)
STR:
1)Start playing video in youtube in portrait mode.
2)Press power key. Display turns off.
3)Press the power key again . Display is ON.
4)Now try changing the deivce orientation from portrait to landscape .
Issue:
Video orientation doesn’t change from portrait to landscape or viceversa
Expected:
Orientation should take effect
Seems like we are registering to disable Orientation
#0 mozilla::hal_impl::SetSensorState (aSensor=aSensor@entry=mozilla::hal::SENSOR_ORIENTATION, activate=activate@entry=false) at ../../../../../../../gecko/hal/gonk/GonkSensor.cpp:252
#1 0xb4f5f1fa in mozilla::hal_impl::DisableSensorNotifications (aSensor=aSensor@entry=mozilla::hal::SENSOR_ORIENTATION) at ../../../../../../../gecko/hal/gonk/GonkSensor.cpp:305
#2 0xb4f5b1d6 in mozilla::hal::DisableSensorNotifications (aSensor=mozilla::hal::SENSOR_ORIENTATION, aSensor@entry=mozilla::hal::SENSOR_ACCELERATION) at ../../../../../../../gecko/hal/Hal.cpp:528
#3 0xb4f5c218 in mozilla::hal::UnregisterSensorObserver (aSensor=aSensor@entry=mozilla::hal::SENSOR_ACCELERATION, aObserver=aObserver@entry=0xaf6ac790) at ../../../../../../../gecko/hal/Hal.cpp:568
#4 0xb5301518 in OrientationObserver::DisableAutoOrientation (this=this@entry=0xaf6ac790) at ../../../../../../../../gecko/widget/gonk/OrientationObserver.cpp:258
#5 0xb53015cc in OrientationObserver::LockScreenOrientation (this=0xaf6ac790, aOrientation=1) at ../../../../../../../../gecko/widget/gonk/OrientationObserver.cpp:288
#6 0xb4f5d112 in mozilla::hal_impl::LockScreenOrientation (aOrientation=@0xabe292e0: 1) at ../../../../../../../gecko/hal/gonk/GonkHal.cpp:860
#7 0xb4f5b474 in mozilla::hal::LockScreenOrientation (aOrientation=@0xabe292e0: 1) at ../../../../../../../gecko/hal/Hal.cpp:725
#8 0xb53b3fd0 in nsScreen::MozLockOrientation (this=this@entry=0xadef5bc0, aOrientations=..., aRv=...) at ../../../../../../../../gecko/dom/base/nsScreen.cpp:273
#9 0xb53b412e in nsScreen::MozLockOrientation (this=this@entry=0xadef5bc0, aOrientation=..., aRv=...) at ../../../../../../../../gecko/dom/base/nsScreen.cpp:234
#10 0xb526a146 in mozilla::dom::ScreenBinding::mozLockOrientation (cx=0xad8aac10, obj=..., self=0xadef5bc0, args=...) at ScreenBinding.cpp:460
#11 0xb52bdcbe in mozilla::dom::GenericBindingMethod (cx=0xad8aac10, argc=<optimized out>, vp=<optimized out>) at ../../../../../../../../gecko/dom/bindings/BindingUtils.cpp:2278
#12 0xb5c8c38a in CallJSNative (args=..., native=0xb52bdc21 <mozilla::dom::GenericBindingMethod(JSContext*, unsigned int, JS::Value*)>, cx=0xad8aac10)
at ../../../../../../../../gecko/js/src/jscntxtinlines.h:239
Comment 2•11 years ago
|
||
Leaving qawanted to see if Moz QA can reproduce & if this reproduces on 1.3.
Component: Gaia::Settings → Gaia::System::Window Mgmt
Keywords: qawanted
Comment 4•11 years ago
|
||
I could NOT reproduce this bug on neither 1.4 nor 1.3. Orientation correctly adjusts to horizontal upon unlocking the device while playing youtube. Since it was not specified in repro steps, I tried playing youtube in both full screen and non full screen. None of them reproduced the bug.
Tested on:
(no repro)
Device: Buri MOZ
BuildID: 20140529000204
Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
Gecko: 2181cac4d0fc
Version: 30.0
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
(no repro)
Device: Buri MOZ
BuildID: 20140530024008
Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
Gecko: 57cd741e4d0b
Version: 28.0
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv28.0) Gecko/28.0 Firefox/28.0
Keywords: qawanted
Comment 5•11 years ago
|
||
(In reply to Pi Wei Cheng from comment #4)
> I could NOT reproduce this bug on neither 1.4 nor 1.3. Orientation correctly
> adjusts to horizontal upon unlocking the device while playing youtube. Since
> it was not specified in repro steps, I tried playing youtube in both full
> screen and non full screen. None of them reproduced the bug.
>
> Tested on:
> (no repro)
> Device: Buri MOZ
> BuildID: 20140529000204
> Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
> Gecko: 2181cac4d0fc
> Version: 30.0
> Firmware Version: v1.2-device.cfg
> User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
>
> (no repro)
> Device: Buri MOZ
> BuildID: 20140530024008
> Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
> Gecko: 57cd741e4d0b
> Version: 28.0
> Firmware Version: v1.2-device.cfg
> User Agent: Mozilla/5.0 (Mobile; rv28.0) Gecko/28.0 Firefox/28.0
Hi
Can you please record your findings based on testing on a QRD?
Comment 6•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #5)
> Hi
>
> Can you please record your findings based on testing on a QRD?
QA doesn't do this style of testing on QRD devices - we don't have enough distribution of devices to do that.
(In reply to Pi Wei Cheng from comment #4)
> I could NOT reproduce this bug on neither 1.4 nor 1.3. Orientation correctly
> adjusts to horizontal upon unlocking the device while playing youtube. Since
> it was not specified in repro steps, I tried playing youtube in both full
> screen and non full screen. None of them reproduced the bug.
>
> Tested on:
> (no repro)
> Device: Buri MOZ
> BuildID: 20140529000204
> Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
> Gecko: 2181cac4d0fc
> Version: 30.0
> Firmware Version: v1.2-device.cfg
> User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
>
> (no repro)
> Device: Buri MOZ
> BuildID: 20140530024008
> Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
> Gecko: 57cd741e4d0b
> Version: 28.0
> Firmware Version: v1.2-device.cfg
> User Agent: Mozilla/5.0 (Mobile; rv28.0) Gecko/28.0 Firefox/28.0
this issue is seen with video app as well
Comment 8•11 years ago
|
||
(In reply to bhargavg1 from comment #7)
> (In reply to Pi Wei Cheng from comment #4)
> > I could NOT reproduce this bug on neither 1.4 nor 1.3. Orientation correctly
> > adjusts to horizontal upon unlocking the device while playing youtube. Since
> > it was not specified in repro steps, I tried playing youtube in both full
> > screen and non full screen. None of them reproduced the bug.
> >
> > Tested on:
> > (no repro)
> > Device: Buri MOZ
> > BuildID: 20140529000204
> > Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
> > Gecko: 2181cac4d0fc
> > Version: 30.0
> > Firmware Version: v1.2-device.cfg
> > User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
> >
> > (no repro)
> > Device: Buri MOZ
> > BuildID: 20140530024008
> > Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
> > Gecko: 57cd741e4d0b
> > Version: 28.0
> > Firmware Version: v1.2-device.cfg
> > User Agent: Mozilla/5.0 (Mobile; rv28.0) Gecko/28.0 Firefox/28.0
>
> this issue is seen with video app as well
Bhargav,
Can you please attach a video of the issue?
Comment 9•11 years ago
|
||
Based on comment 4, calling this out as a regression since 1.4. Need a regression window to identify the cause.
Flags: needinfo?(timdream) → needinfo?(alive)
Keywords: regression,
regressionwindow-wanted
Comment 11•11 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #9)
> Based on comment 4, calling this out as a regression since 1.4. Need a
> regression window to identify the cause.
comment 4 indicates that we can't reproduce, so we can't do a window here nor prove that it's a regression.
Keywords: regressionwindow-wanted
Updated•11 years ago
|
Keywords: regression
Comment 12•11 years ago
|
||
Inder,
Please help with a video here. ni Bharghav as well.
Flags: needinfo?(ikumar)
Reporter | ||
Comment 13•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #8)
> > Gecko/28.0 Firefox/28.0
> >
> > this issue is seen with video app as well
>
> Bhargav,
>
> Can you please attach a video of the issue?
Video showing the issue is at, https://drive.google.com/file/d/0B0zTAnPOpx-xQXpLUDN5OXF1OW8/edit?usp=sharing
Flags: needinfo?(bhargavg1)
Updated•11 years ago
|
Whiteboard: [CR 673422] → [caf priority: p2][CR 673422]
Comment 14•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #8)
> (In reply to bhargavg1 from comment #7)
> > (In reply to Pi Wei Cheng from comment #4)
> > > I could NOT reproduce this bug on neither 1.4 nor 1.3. Orientation correctly
> > > adjusts to horizontal upon unlocking the device while playing youtube. Since
> > > it was not specified in repro steps, I tried playing youtube in both full
> > > screen and non full screen. None of them reproduced the bug.
> > >
> > > Tested on:
> > > (no repro)
> > > Device: Buri MOZ
> > > BuildID: 20140529000204
> > > Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
> > > Gecko: 2181cac4d0fc
> > > Version: 30.0
> > > Firmware Version: v1.2-device.cfg
> > > User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
> > >
> > > (no repro)
> > > Device: Buri MOZ
> > > BuildID: 20140530024008
> > > Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
> > > Gecko: 57cd741e4d0b
> > > Version: 28.0
> > > Firmware Version: v1.2-device.cfg
> > > User Agent: Mozilla/5.0 (Mobile; rv28.0) Gecko/28.0 Firefox/28.0
> >
> > this issue is seen with video app as well
>
> Bhargav,
>
> Can you please attach a video of the issue?
Added Attachment.
Also if we once go to home screen and come back to browser app then issue goes away (same is in attachment also)
Comment 15•11 years ago
|
||
(In reply to bhargavg1 from comment #13)
> (In reply to Preeti Raghunath(:Preeti) from comment #8)
> > > Gecko/28.0 Firefox/28.0
> > >
> > > this issue is seen with video app as well
> >
> > Bhargav,
> >
> > Can you please attach a video of the issue?
>
> Video showing the issue is at,
> https://drive.google.com/file/d/0B0zTAnPOpx-xQXpLUDN5OXF1OW8/edit?usp=sharing
Based on the video here, can we reproduce this on 1.4 Flame?
Keywords: qawanted
Comment 16•11 years ago
|
||
I was not able to reproduce this on the Flame 1.4 in either the browser on Youtube or the Video app.
In Youtube the video does not stay full screen after unlocking the device contrary to what is shown in the video.
Device: Flame 1.4
Build ID: 20140604000202
Gaia: 0c16adced7c51f795ef250aebe184f60b6a9b987
Gecko: 04216748e6c1
Version: 30.0 (1.4)
Firmware Version: v10G-2
Keywords: qawanted
QA Contact: lmauritson
Reporter | ||
Comment 17•11 years ago
|
||
(In reply to Lionel Mauritson from comment #16)
> I was not able to reproduce this on the Flame 1.4 in either the browser on
> Youtube or the Video app.
> In Youtube the video does not stay full screen after unlocking the device
> contrary to what is shown in the video.
>
> Device: Flame 1.4
> Build ID: 20140604000202
> Gaia: 0c16adced7c51f795ef250aebe184f60b6a9b987
> Gecko: 04216748e6c1
> Version: 30.0 (1.4)
> Firmware Version: v10G-
From comment 14 video we don't even need to enter full screen mode, were you able to reproduce issue as in comment 14
Flags: needinfo?(lmauritson)
Comment 18•11 years ago
|
||
(In reply to bhargavg1 from comment #17)
> (In reply to Lionel Mauritson from comment #16)
> > I was not able to reproduce this on the Flame 1.4 in either the browser on
> > Youtube or the Video app.
> > In Youtube the video does not stay full screen after unlocking the device
> > contrary to what is shown in the video.
> >
> > Device: Flame 1.4
> > Build ID: 20140604000202
> > Gaia: 0c16adced7c51f795ef250aebe184f60b6a9b987
> > Gecko: 04216748e6c1
> > Version: 30.0 (1.4)
> > Firmware Version: v10G-
>
> From comment 14 video we don't even need to enter full screen mode, were you
> able to reproduce issue as in comment 14
I was not able to reproduce this.
I tried both with and without using full screen, locking and unlocking in different orientations then rotating, rotating while locked and then unlocking and rotating, etc. On my Flame the video was always able to rotate correctly to match the orientation after unlocking the device in both Youtube and the Video app. Perhaps the device's gyro is affected by locking?
Flags: needinfo?(lmauritson)
Comment 19•11 years ago
|
||
Well, I cannot repro on 2.0 + 1.4
Recommend to closed as WORKSFORME.
Flags: needinfo?(alive)
Comment 20•11 years ago
|
||
Agree.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Updated•11 years ago
|
blocking-b2g: 1.4? → ---
Updated•11 years ago
|
Whiteboard: [caf priority: p2][CR 673422] → [caf priority: p3][CR 673422]
Comment 21•11 years ago
|
||
Have you (In reply to Lionel Mauritson from comment #18)
> I was not able to reproduce this.
> I tried both with and without using full screen, locking and unlocking in
> different orientations then rotating, rotating while locked and then
> unlocking and rotating, etc. On my Flame the video was always able to rotate
> correctly to match the orientation after unlocking the device in both
> Youtube and the Video app. Perhaps the device's gyro is affected by locking?
Have you tried with ui screen lock enabled? If so can you please try after disabling it?
I see after starting youtube playback, power key suspend and power key resume, code reaches
here [1] which locks orientation.
Then until somewhere else mozUnlockOrientation is called, orientation doesn't work.
From video, you can see that, it stopped working after suspend, resume and started working again after switching to homescreen and back to browser.
[1] https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/lockscreen.js#L164
Flags: needinfo?(lmauritson)
Flags: needinfo?(alive)
Comment 22•11 years ago
|
||
(In reply to vasanth from comment #21)
> Have you tried with ui screen lock enabled? If so can you please try after
> disabling it?
> I see after starting youtube playback, power key suspend and power key
> resume, code reaches
> here [1] which locks orientation.
>
> Then until somewhere else mozUnlockOrientation is called, orientation
> doesn't work.
> From video, you can see that, it stopped working after suspend, resume and
> started working again after switching to homescreen and back to browser.
>
> [1]
> https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/lockscreen.
> js#L164
I assume you mean Settings -> Display -> Lock orientation ?
I did not have it enabled when testing this. When it is activated the video does not rotate at all. Let me know if you meant a different setting.
When I was testing the video would rotate just fine when I turned the device, but it would never become "stuck" in a particular orientation.
I've included a video of my method for your review: http://youtu.be/E8hD1J85n9I
Let me know if I am not doing it right.
Builds used in video:
Device: Flame 2.0
Build ID: 20140605061016
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: 219b3ed1b996
Version: 32.0a1 (2.0)
Firmware Version: v10G-2
Device: Flame 1.4
Build ID: 20140605000203
Gaia: 1f238df7ac68a73a4ceb27391a204c800f38ab1c
Gecko: a7b7f1b579cc
Version: 30.0 (1.4)
Firmware Version: v10G-2
Flags: needinfo?(lmauritson)
Comment 23•11 years ago
|
||
(In reply to Lionel Mauritson from comment #22)
> I assume you mean Settings -> Display -> Lock orientation ?
From Screen lock we meant "Settings->Screen lock"
Comment 24•11 years ago
|
||
(In reply to vasanth from comment #21)
> Have you (In reply to Lionel Mauritson from comment #18)
> > I was not able to reproduce this.
> > I tried both with and without using full screen, locking and unlocking in
> > different orientations then rotating, rotating while locked and then
> > unlocking and rotating, etc. On my Flame the video was always able to rotate
> > correctly to match the orientation after unlocking the device in both
> > Youtube and the Video app. Perhaps the device's gyro is affected by locking?
>
> Have you tried with ui screen lock enabled? If so can you please try after
> disabling it?
> I see after starting youtube playback, power key suspend and power key
> resume, code reaches
> here [1] which locks orientation.
>
> Then until somewhere else mozUnlockOrientation is called, orientation
> doesn't work.
> From video, you can see that, it stopped working after suspend, resume and
> started working again after switching to homescreen and back to browser.
>
> [1]
> https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/lockscreen.
> js#L164
Yeah, we do that because we don't want lockscreen to be landscape,
but please see
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/lockscreen.js#L138
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/lockscreen.js#L654
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/orientation_manager.js#L35
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/app_window_manager.js#L212
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/app_window_manager.js#L294
When screenchange triggers will-unlock the appWindowManager will make active app to lock/unlock the screen orientation according to its manifest.
Flags: needinfo?(alive)
Comment 25•11 years ago
|
||
I still cannot reproduce with 2.0 master even if I flip the settings. Trying 1.4
Comment 26•11 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #24)
> When screenchange triggers will-unlock the appWindowManager will make active
> app to lock/unlock the screen orientation according to its manifest.
AFAICK in V1.4, screenchange doesn't trigger "will-unlock" when we disabled UI screenlock in settings
Comment 27•11 years ago
|
||
(In reply to vasanth from comment #26)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #24)
> > When screenchange triggers will-unlock the appWindowManager will make active
> > app to lock/unlock the screen orientation according to its manifest.
>
> AFAICK in V1.4, screenchange doesn't trigger "will-unlock" when we disabled
> UI screenlock in settings
If so this is a bug.
Comment 28•11 years ago
|
||
Just confirmed for v1.4 we have a bad lockscreen state management. The fast fix should be trigger will-unlock always.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Updated•11 years ago
|
blocking-b2g: --- → 1.4?
Comment 30•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #29)
> Alive,
>
> Please provide next steps here?
It's a gaia bug and may be a regression or not. I want to have some regression range.
Flags: needinfo?(alive)
Keywords: regressionwindow-wanted
Comment 31•11 years ago
|
||
Alive - I need a way for my testers to be able to reproduce this with pvtbuilds in order to do a window. Does this reproducing require a custom Gaia build or not?
Flags: needinfo?(alive)
Comment 32•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #31)
> Alive - I need a way for my testers to be able to reproduce this with
> pvtbuilds in order to do a window. Does this reproducing require a custom
> Gaia build or not?
Jason, this is a gaia 1.4 only bug. Please test with gaia v1.4.
Flags: needinfo?(alive)
Updated•11 years ago
|
Keywords: regression
Comment 34•11 years ago
|
||
Bhargav,
Please help with regression range when you get a chance.
Flags: needinfo?(vasanth)
Flags: needinfo?(bhargavg1)
Comment 35•11 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #28)
> Just confirmed for v1.4 we have a bad lockscreen state management. The fast
> fix should be trigger will-unlock always.
What device did we test with?
Reporter | ||
Comment 36•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #34)
> Bhargav,
>
> Please help with regression range when you get a chance.
The first time we checked this wasnt working, so really not sure if this was working at all
Flags: needinfo?(vasanth)
Flags: needinfo?(bhargavg1)
Comment 37•11 years ago
|
||
(In reply to bhargavg1 from comment #36)
> (In reply to Preeti Raghunath(:Preeti) from comment #34)
> > Bhargav,
> >
> > Please help with regression range when you get a chance.
>
> The first time we checked this wasnt working, so really not sure if this was
> working at all
This can't be regression then. Its probably a broken feature but not regression.
Updated•11 years ago
|
QA Contact: lmauritson → jmercado
Comment 38•11 years ago
|
||
Flagging according to comment 32.
Updated•11 years ago
|
Comment 39•11 years ago
|
||
This issue's window was earlier than the builds available for Flame so I used a Buri instead.
Mozilla Aurora engineering regression window:
Last working Environmental Variables:
Device: Buri
Build ID: 20140415104758
Gaia: a33220809a624f954bd75ddb2ff718e7c758392a
Gecko: e23cf1b530f7
Version: 30.0a2
First Broken Environmental Variables:
Device: Buri
BuildID: 20140415111359
Gaia: 9cc1b7684c969ed7dd4b8242c56e2fe1d10bc6f3
Gecko: 562f35fec017
Version: 30.0a2
Last working gaia / First broken gecko - does not occur
Gaia: a33220809a624f954bd75ddb2ff718e7c758392a
Gecko: 562f35fec017
First broken gaia / Last working gekko - issue occurs- indicates gaia issue
Gaia: 9cc1b7684c969ed7dd4b8242c56e2fe1d10bc6f3
Gecko: e23cf1b530f7
Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/a33220809a624f954bd75ddb2ff718e7c758392a...9cc1b7684c969ed7dd4b8242c56e2fe1d10bc6f3
Keywords: regressionwindow-wanted
Updated•11 years ago
|
Assignee: nobody → alive
Comment 40•11 years ago
|
||
So that means this is not a regression but v2.0 accidently fixed it. I guess it's due to lockscreenWindow refactor.
Comment 41•11 years ago
|
||
Greg, if you want to take this please do. The fix should be happening in lockscreen.js
Flags: needinfo?(gweng)
Assignee | ||
Updated•11 years ago
|
Assignee: alive → gweng
Component: Gaia::System::Window Mgmt → Gaia::System::Lockscreen
Comment 43•11 years ago
|
||
Greg,
Do you need any information to take your investigation further? Please let me know if we need help from partner?
Flags: needinfo?(gweng)
Assignee | ||
Comment 46•11 years ago
|
||
Sorry, typo. I'd resolved this issue (see the video).
I'm going to submit the patch.
Assignee | ||
Comment 47•11 years ago
|
||
Now it would lock the orientation only when the component want to lock the screen, and I also fixed another locking code which should be executed only after we really want to lock the screen.
Attachment #8440378 -
Flags: review?(alive)
Updated•11 years ago
|
Flags: needinfo?(timdream)
Comment 48•11 years ago
|
||
Comment on attachment 8440378 [details] [review]
Patch
It'd be better if the lock orientation call is in only one place.
Attachment #8440378 -
Flags: review?(alive) → review+
Assignee | ||
Comment 49•11 years ago
|
||
Travis is green:
https://travis-ci.org/mozilla-b2g/gaia/builds/27608401
However TBPL has lots of timeout. I'm going to re-trigger those jobs.
Assignee | ||
Comment 51•11 years ago
|
||
OK, I've re-triggered all jobs. Now I'm waiting the result again.
The timeout is something like:
...timed out after 1760 seconds of no output
And I really don't feel it's caused by my patch, but only the result can speak.
Flags: needinfo?(gweng)
Assignee | ||
Comment 52•11 years ago
|
||
It still report the same errors. And I've heard that TBPL hasn't had support for different release branches, so I would land the patch according to the Travis result.
Assignee | ||
Comment 53•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 2.0 S4 (20june)
Comment 54•10 years ago
|
||
For this to be covered, a new test case must be made.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(srapanan)
Comment 55•10 years ago
|
||
Test case has been added to moztrap:
https://moztrap.mozilla.org/manage/case/14352/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(srapanan)
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•