Closed
Bug 1018365
Opened 10 years ago
Closed 10 years ago
Remove extraneous $(shell) in package-name.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: mshal, Assigned: mshal)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
We have a useless $(shell) in package-name.mk: MOZ_PKG_LONGVERSION = $(shell echo $(MOZ_PKG_VERSION))
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8431778 -
Flags: review?(mh+mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8431778 [details] [diff] [review] 0002-Bug-1018365-Remove-useless-shell.patch Review of attachment 8431778 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/installer/package-name.mk @@ -84,2 @@ > ifndef MOZ_PKG_LONGVERSION > -MOZ_PKG_LONGVERSION = $(shell echo $(MOZ_PKG_VERSION)) wtf?
Attachment #8431778 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/dfd6b607988d
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dfd6b607988d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•