Closed Bug 1018447 Opened 10 years ago Closed 9 years ago

Encoding issues in newsletter country select on homepage for some locales

Categories

(www.mozilla.org :: Product Details, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: theo, Assigned: kohei)

References

Details

(Whiteboard: [kb=1399049] )

Attachments

(3 files, 2 obsolete files)

Attached image Frysk.png
On http://www.mozilla.org/fy-NL/ for instance, go to the newsletter section and click on the e-mail field: there are Python encoding issues with some country localized names.
The list I'm seeing is correct, both on prod and dev. Could be a temporary glitch?
I checked on Firefox and Chrome, with Linux and Mac OS, still seeing the issue :/ Maybe encoding setting issue?
Never mind, I should learn to read bug subjects. I was looking at the language switcher in the footer, not at the mailing list one.
Whiteboard: [kb=1399049]
Attached file pull request (obsolete) —
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Attached patch patch for product-details (obsolete) — Splinter Review
As :pmac said in the PR, this should be solved in the data itself. Here's a patch for the product-details lib to fix the problematic JSON data and script.
Attachment #8525629 - Attachment is obsolete: true
Attachment #8526357 - Flags: review?(pmac)
Attached patch patch v1.1Splinter Review
Fixed the eo locale output having NULL.
Attachment #8526357 - Attachment is obsolete: true
Attachment #8526357 - Flags: review?(pmac)
Attachment #8526360 - Flags: review?(pmac)
Component: Bedrock → Product Details
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 8526360 [details] [diff] [review]
patch v1.1

Review of attachment 8526360 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me, but I'd like someone more familiar with the PHP to take a look. Pinged Sylvestre.
Attachment #8526360 - Flags: review?(sledru)
Attachment #8526360 - Flags: review?(pmac)
Attachment #8526360 - Flags: review+
Comment on attachment 8526360 [details] [diff] [review]
patch v1.1

That looks great.
I have just a small comment. Could you make two commits?
One with the actual change in the generation.
The second with json updates files.
Attachment #8526360 - Flags: review?(sledru) → review+
I don't have write access to the product-details directory, so could you commit this? As the first patch shows, quotes in eo.properties lead to a decode error, so I just removed them.

Then running ./export_json.php as always should generate the updated JSON files.

Thanks!
Flags: needinfo?(sledru)
I am in PTO. I could commit that now but if there is any issue, I would not be around to handle that.
N-I pascal if he can take care of that for me.
Flags: needinfo?(sledru) → needinfo?(pascalc)
Back from PTO, here it is:
http://viewvc.svn.mozilla.org/vc?view=revision&revision=135714
http://viewvc.svn.mozilla.org/vc?view=revision&revision=135715
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(pascalc)
Resolution: --- → FIXED
Thanks!
Fixed on prod: https://www.mozilla.org/fy-NL/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: