Closed
Bug 1018447
Opened 10 years ago
Closed 9 years ago
Encoding issues in newsletter country select on homepage for some locales
Categories
(www.mozilla.org :: Product Details, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: theo, Assigned: kohei)
References
Details
(Whiteboard: [kb=1399049] )
Attachments
(3 files, 2 obsolete files)
402.11 KB,
image/png
|
Details | |
67.40 KB,
patch
|
pmac
:
review+
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
Details | Diff | Splinter Review |
On http://www.mozilla.org/fy-NL/ for instance, go to the newsletter section and click on the e-mail field: there are Python encoding issues with some country localized names.
Comment 1•10 years ago
|
||
The list I'm seeing is correct, both on prod and dev. Could be a temporary glitch?
Reporter | ||
Comment 2•10 years ago
|
||
I checked on Firefox and Chrome, with Linux and Mac OS, still seeing the issue :/ Maybe encoding setting issue?
Comment 3•10 years ago
|
||
Never mind, I should learn to read bug subjects. I was looking at the language switcher in the footer, not at the mailing list one.
Updated•10 years ago
|
Whiteboard: [kb=1399049]
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
As :pmac said in the PR, this should be solved in the data itself. Here's a patch for the product-details lib to fix the problematic JSON data and script.
Attachment #8525629 -
Attachment is obsolete: true
Attachment #8526357 -
Flags: review?(pmac)
Assignee | ||
Comment 6•10 years ago
|
||
Fixed the eo locale output having NULL.
Attachment #8526357 -
Attachment is obsolete: true
Attachment #8526357 -
Flags: review?(pmac)
Attachment #8526360 -
Flags: review?(pmac)
Assignee | ||
Updated•10 years ago
|
Component: Bedrock → Product Details
OS: Linux → All
Hardware: x86_64 → All
Comment 7•10 years ago
|
||
Comment on attachment 8526360 [details] [diff] [review] patch v1.1 Review of attachment 8526360 [details] [diff] [review]: ----------------------------------------------------------------- Looks right to me, but I'd like someone more familiar with the PHP to take a look. Pinged Sylvestre.
Attachment #8526360 -
Flags: review?(sledru)
Attachment #8526360 -
Flags: review?(pmac)
Attachment #8526360 -
Flags: review+
Comment 9•10 years ago
|
||
Comment on attachment 8526360 [details] [diff] [review] patch v1.1 That looks great. I have just a small comment. Could you make two commits? One with the actual change in the generation. The second with json updates files.
Attachment #8526360 -
Flags: review?(sledru) → review+
Assignee | ||
Comment 10•10 years ago
|
||
I don't have write access to the product-details directory, so could you commit this? As the first patch shows, quotes in eo.properties lead to a decode error, so I just removed them. Then running ./export_json.php as always should generate the updated JSON files. Thanks!
Flags: needinfo?(sledru)
Comment 11•10 years ago
|
||
I am in PTO. I could commit that now but if there is any issue, I would not be around to handle that. N-I pascal if he can take care of that for me.
Flags: needinfo?(sledru) → needinfo?(pascalc)
Comment 12•9 years ago
|
||
Back from PTO, here it is: http://viewvc.svn.mozilla.org/vc?view=revision&revision=135714 http://viewvc.svn.mozilla.org/vc?view=revision&revision=135715
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(pascalc)
Resolution: --- → FIXED
Assignee | ||
Comment 13•9 years ago
|
||
Thanks!
Assignee | ||
Comment 14•9 years ago
|
||
Fixed on dev: https://www-dev.allizom.org/fy-NL/
Assignee | ||
Comment 15•9 years ago
|
||
Fixed on prod: https://www.mozilla.org/fy-NL/
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•