1018474 - [B2G][Dialer] Inbound call icon missing in call log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
When user receives an inbound call, the inbound call icon is missing from the dialer apps call log. Missed and outbound calls appear correctly. All other call information appears correctly.

Repro Steps:
1) Updated Flame to BuildID: 20140530040207
2) Receive inbound call.
3) Launch dialer and open call log

Actual:
Inbound call icons are missing from call log in dialer.

Expected:
Inbound call icons are present for call log in dialer.

Environmental Variables:
Device: Flame v2.0 Master M-C Mozilla RIL
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v10G-2

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot & logcat

Comment 1

[Jason Smith [:jsmith]]

Let's verify this isn't happening on 1.4.

Comment 2

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Buri 2.0 

Results: Inbound call icons are missing from call log in dialer.

Environmental Variables:
Device: Buri v2.0 Master M-C Mozilla RIL
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Comment 3

[Brogan Zumwalt [Inactive]]

Issue does NOT occur on Flame 1.4

Result: Inbound call icons are present for call log in dialer.

Environmental Variables:
Device: Flame v1.4 Mozilla RIL
BuildID: 20140530000202
Gaia: fe612fd21389193a8e593aa718831602e5086a62
Gecko: 25011f9a8f26
Version: 30.0
Firmware Version: v10G-2

Comment 4

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

User agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[Lionel Mauritson]

>Mozilla Central Flame Engineering

Last Working
Build ID: 20140529133000
Gaia: b669dd2cc321f37cebc7081a79b968cac36b4200
Gecko: b85b57f05fda
Version: 32.0a1 (2.0) 

First Broken
Build ID: 20140529193003
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: 38c5e21a80fa
Version: 32.0a1 (2.0) 

>Swap Gaia & Gecko

New_Gaia_Old_Gecko: Broken
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: b85b57f05fda

Old_Gaia_New_Gecko: Working
Gaia: b669dd2cc321f37cebc7081a79b968cac36b4200
Gecko: 38c5e21a80fa

Determined to be a Gaia issue.
>Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/b669dd2cc321f37cebc7081a79b968cac36b4200...26d8fcab9b61f46451600f39c51e0387ef3c4f88

>B2G Inbound

Last Working
BuildID: 20140529083004
Gaia: d5dcbabd1ad07d5fd30a7875a9a80817bc93619c
Gecko: f72106cb1769

First Broken
BuildID: 20140529113002
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: 8630b86e15c7

>Swap Gaia & Gecko

New_Gaia_Old_Gecko - Broken
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: f72106cb1769

Old_Gaia_New_Gecko - Working
Gaia: d5dcbabd1ad07d5fd30a7875a9a80817bc93619c
Gecko: 8630b86e15c7

>Narrowed down Gaia pushlog: 
https://github.com/mozilla-b2g/gaia/compare/d5dcbabd1ad07d5fd30a7875a9a80817bc93619c...26d8fcab9b61f46451600f39c51e0387ef3c4f88

Comment 6

[Jason Smith [:jsmith]]

Broken by bug 951606.

German - Can you take a look?

Comment 7

[Paco Rampas [:paco]]

Attachment: incoming-icon.png

Comment 8

[Paco Rampas [:paco]]

Attachment: patch in github

This bug is fixing, but I haven't a fubu for testing in dual sim phone, therefore I ask feedback to Arnau because I think he has a fugu. Could you test it, Arnau? Thanks. 
:D

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8433287 [details] [review]
patch in github

I've tested on a Flame with Dual SIM support and it fixes it.

No need to wait for Arnau's feedback.

Comment 10

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8433278 [details]
incoming-icon.png

Icons have a different kind of grey (ones are #40464f and others #575757), please make all in #575757

Comment 11

[Paco Rampas [:paco]]

Attachment: incoming-icon.png

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 73abc5160710c1288cb0c6a5d030863189bb8fb8

Comment 13

[Natalya Kot [:nkot]]

Verified Fixed in today's trunk - Inbound call icons are present for Call Log in Dialer/

Flame 2.0
BuildID: 20140606040202
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: c8288d0c7a15
Version: 32.0a1
v10G-2