1018492 - gaia-tabs should have correct accessibility roles

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Eitan Isaacson [:eeejay]]

While there is aria-selected - which is nice, we don't have any roles for the tabs. Also, putting in correct accessibility in the example html would be useful.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8431978 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843

Clearing review for now. I made one comment on github, and would like to know what you think. Thanks!

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8431978 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
> 
> Clearing review for now. I made one comment on github, and would like to
> know what you think. Thanks!

Replied in github.

Comment 4

[Eitan Isaacson [:eeejay]]

This this is good enough?

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8431978 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843

re-requesting review after answering issues in PR, and rebasing.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8431978 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843

Redirecting review to wilson - i am currently overloaded with 2.0 stuff, sorry.

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

I've ported gaia-tabs along with eejay's patch over to github.com/gaia-componets/gaia-tabs. Also added couple of tests.

No apps currently depend on this component.

Comment 8

[Wilson Page [:wilsonpage]]

http://github.com/gaia-components/gaia-tabs

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8444529 [details] [review]
pull-request (master)

Hey Wilson - after spending the last several weeks working on components for the verical homescreen, I had a chat with the homescreen team and feel that for now, until everything is ready, that we need to keep components internal to gaia in order to move quickly.

This does not mean that we should not continue to experiment with external components, but let's keep them internal to gaia while we solve all of our problems.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8431978 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843

Looks fine to me, and sounds like we implemented it in the external repository approach. Let's land in gaia for now while we continue to experiment.

Comment 11

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/45479c07cb6ba8c733093d6ee32c767c090c9a28