1018515 - Remove "GoogleLink" provider from search app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Dale Harvey (:daleharvey)]

Will be replaced by configurable search engines https://bugzilla.mozilla.org/show_bug.cgi?id=1009353

Its also ugly and getting rid of it helps a bunch of in progress patches

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19845

This isnt part of any current specs

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8432072 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19845

Hmm, you sure? I am fairly certain I saw the googlelink provider moved into the icon in some recent search spec. Ni? on Francis..

Comment 3

[Dale Harvey (:daleharvey)]

e.me provide a google link in their search results, I assumed that was what existed in any specs. It seems strange to me if carriers have specifically set e.me to be the sole search provider that we would maintain this hack.

Comment 4

[Kevin Grandon :kgrandon]

Let's wait for Francis to respond, but I believe this was the same thing as before - show the icon first, when E.me does not have a result. I think the behavior is to go back to commit 47c95468061f61d96614177bd89edbe165b7d6a6.

Comment 5

[Francis Djabri [:djabber]]

Dale is right. The google link was put in to give users an easy way to get to google, but we don't need this anymore as we are allowing users to set the default search provider.

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8432072 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19845

Rebased and reflagging for review based on comment, cheers Francis

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/57bebd32ffebb1e5482aa611c5c283f36307184d

(Squashed the removal of googlelink into your commit)

Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Oops - looks like we both landed commits to this bug that should've been a part of bug 1017222. Just making a note in case there is any future problems or need for backout.