Closed Bug 1018555 Opened 10 years ago Closed 10 years ago

Fix -Wreorder warnings in js/src/jsgc.cpp

Categories

(Core :: JavaScript: GC, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1013531
Tracking Status
firefox31 --- unaffected
firefox32 --- affected

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

These are new clang warnings from AutoCheckCannotGC bug 1013531:

js/src/jsgc.cpp:1118:5 [-Wreorder] field 'helperState' will be initialized after field 'alwaysPreserveCode'
js/src/jsgc.cpp:1124:5 [-Wreorder] field 'lockOwner' will be initialized after field 'inUnsafeRegion'
Attachment #8432061 - Flags: review?(terrence)
Comment on attachment 8432061 [details] [diff] [review]
fix-Wreorder-warnings.patch

Review of attachment 8432061 [details] [diff] [review]:
-----------------------------------------------------------------

D'oh! I thought I fixed that before pushing. Thanks for the fix.
Attachment #8432061 - Flags: review?(terrence) → review+
Independently fixed by patch in the original bug.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: