"Your account has been reconnected" message not displayed in private conversations if the other party is not a contact

RESOLVED FIXED in 1.6

Status

Chat Core
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The "Your account has been reconnected" system message is shown only in MUCs and not in private conversation tabs.
(Assignee)

Comment 1

3 years ago
Created attachment 8432135 [details] [diff] [review]
Patch
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #8432135 - Flags: review?(aleth)
(Assignee)

Updated

3 years ago
Summary: "Your account has been reconnected" message not displayed in private conversations → "Your account has been reconnected" message not displayed in private conversations if the other party is not a contact

Comment 2

3 years ago
Comment on attachment 8432135 [details] [diff] [review]
Patch

Review of attachment 8432135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please add a comment explaining that the this.contact check is because the conversation doesn't receive presence updates for convs with non-contacts.
Attachment #8432135 - Flags: review?(aleth) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8432651 [details] [diff] [review]
Patch v2 (better comment)
Attachment #8432135 - Attachment is obsolete: true
Attachment #8432651 - Flags: review?(aleth)

Comment 4

3 years ago
Comment on attachment 8432651 [details] [diff] [review]
Patch v2 (better comment)

Review of attachment 8432651 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8432651 - Flags: review?(aleth) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/babb5e26c4ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.