Closed
Bug 1018602
Opened 12 years ago
Closed 12 years ago
"Your account has been reconnected" message not displayed in private conversations if the other party is not a contact
Categories
(Chat Core :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.42 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
The "Your account has been reconnected" system message is shown only in MUCs and not in private conversation tabs.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Summary: "Your account has been reconnected" message not displayed in private conversations → "Your account has been reconnected" message not displayed in private conversations if the other party is not a contact
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8432135 [details] [diff] [review]
Patch
Review of attachment 8432135 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Please add a comment explaining that the this.contact check is because the conversation doesn't receive presence updates for convs with non-contacts.
Attachment #8432135 -
Flags: review?(aleth) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #8432135 -
Attachment is obsolete: true
Attachment #8432651 -
Flags: review?(aleth)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8432651 [details] [diff] [review]
Patch v2 (better comment)
Review of attachment 8432651 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8432651 -
Flags: review?(aleth) → review+
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•