Closed Bug 1018602 Opened 8 years ago Closed 8 years ago

"Your account has been reconnected" message not displayed in private conversations if the other party is not a contact

Categories

(Chat Core :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file, 1 obsolete file)

The "Your account has been reconnected" system message is shown only in MUCs and not in private conversation tabs.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #8432135 - Flags: review?(aleth)
Summary: "Your account has been reconnected" message not displayed in private conversations → "Your account has been reconnected" message not displayed in private conversations if the other party is not a contact
Comment on attachment 8432135 [details] [diff] [review]
Patch

Review of attachment 8432135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please add a comment explaining that the this.contact check is because the conversation doesn't receive presence updates for convs with non-contacts.
Attachment #8432135 - Flags: review?(aleth) → review-
Attachment #8432135 - Attachment is obsolete: true
Attachment #8432651 - Flags: review?(aleth)
Comment on attachment 8432651 [details] [diff] [review]
Patch v2 (better comment)

Review of attachment 8432651 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8432651 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/babb5e26c4ed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.