Open Bug 101863 Opened 23 years ago Updated 2 years ago

nsAboutCacheEntry buffer cleanup

Categories

(Core :: Networking: Cache, defect, P5)

Product:
Core
Component:
Networking: Cache
Type:
defect

Tracking

()

People

(Reporter: darin.moz, Unassigned)

References

(
URL
)

Details

(Whiteboard: [necko-would-take]) 

see discussion in bug 96768 concerning cleaning up the buffering in
nsAboutCacheEntry.cpp
-> future
Priority: -- → P5
Target Milestone: --- → Future
TYPO: see discussion in bug 95768 concerning cleaning up the buffering in
nsAboutCacheEntry.cpp
Bug 120404 needs locale specific date representation, and this requires change
of buffer from nsCString to nsString (I think).

Other changes we've discussed:
* use of a global nsString buffer, instead of global buffer pointer, and stop
passing it to the visitor.
* use of a simple nsString buffer and NS_NewStringInputStream instead of a
storage stream.

Also maybe some string clean up:
* use of NS_LITERAL_STRING() for markup text
* use of += (if possible?) instead of .Append
Blocks: 120404
(should this go to cache?)
QA Contact: benc → tever
bug 165821 contains a patch that makes about:cache load asynchonously... there's
buffer cleanup there as well, which might make this bug a duplicate.
Depends on: 165821
Not really.
Bug 165821 deals with about:cache while this one is about:cache-entry.
So they don't intersect.

However for bug 120404, about:cache buffer probably has to be changed from
nsCString to nsString as well.
No longer depends on: 165821
whoops, you're right ;-)  as for nsString vs. nsCString... we can't really
stream UCS-2 over to the HTML parser... it should be UTF-8 if it needs to be
unicode.
-> cache, Networking cleanup.

If this belonged in Networking, please return it w/ a comment explaining why, as
requested in #4.
Component: Networking → Networking: Cache
Note also that the CacheVisitor idl needs to be cleaned for string usage...
Note also that the CacheVisitor idl needs to be cleaned for string usage...
-> default owner
Assignee: darin → nobody
QA Contact: tever → networking.cache
Target Milestone: Future → ---
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.