Closed Bug 1018666 Opened 8 years ago Closed 8 years ago

Capitalize accesskeys correctly in colors preferences

Categories

(Firefox :: Preferences, defect)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
firefox32 --- verified

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

Details

(Keywords: access)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #189315 +++

Capitalize accesskey for Tex_t_ in colors preferences

Several accesskeys in colors.dtd have lower-case letters whereas their actual label has an upper-case letter. This was fixed in the Mozilla Suite but not in Firefox (and copy-pasted for Thunderbird which I'm fixing as part of bug 920118). This is most obvious in the "Text:" label which underlines the last 't' rather than the first 'T' character as accesskey.
Attached patch Proposed patchSplinter Review
Direct port of attachment 8432226 [details] [diff] [review] for Thunderbird (now bug 1018718).
Attachment #8432229 - Flags: review?(dolske)
(no revision of entity names given that it's an en-US local change only without change in semantics.)
Attachment #8432229 - Flags: review?(dolske) → review+
Thanks Dão, push for mozilla-inbound/central please.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/816084978ed1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Hi, 

I was able to reproduce it on Nightly 32.0a1 2014-06-03 on Debian x86_64 and Windows 7 x86_64 and I can confirm that it's fixed in latest Nightly 32.0a1 2014-06-04 on both platforms.

Having checked two platforms out of three, I'm marking this as verified.

Cheers, 
Francesca
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20140604]
You need to log in before you can comment on or make changes to this bug.