Closed
Bug 1018699
Opened 10 years ago
Closed 10 years ago
Create gaia-checkbox web component
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8432201 [details] [review] Github pull request Hey Guys - This is very much inline with the gaia-radio/gaia-switch components. It has similar event handling and content selection with the label inside of the component. I think once this is landed we can iterate on all three controls in parallel and make sure that they are pleasant to implement and work with. Please take a look when you get the chance. Thanks!
Attachment #8432201 -
Flags: review?(yor)
Attachment #8432201 -
Flags: review?(wilsonpage)
Attachment #8432201 -
Flags: review?(arnau)
Comment on attachment 8432201 [details] [review] Github pull request Looks good. I see that we are using "class" here where as gaia-header uses "skin". Should we standardize on one?
Attachment #8432201 -
Flags: review?(yor) → review+
|
||
Updated•10 years ago
|
Target Milestone: 2.0 S3 (6june) → ---
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8432201 [details] [review] Github pull request Let's keep moving on these... thanks for the review Yan. I think class and skin can both have distinct roles. E.g., you might want class="danger" and skin="dark". I don't think we've deviated too far yet, but we can always align if needed.
Attachment #8432201 -
Flags: review?(wilsonpage)
Attachment #8432201 -
Flags: review?(arnau)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/981168caafb6e22e874c7a7102b3bbf491da4e51
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•