Closed Bug 1018701 Opened 6 years ago Closed 6 years ago

Move media-samples folder into test_media

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S3 (6june)

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

(Whiteboard: [p=1],[systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
We have a media-samples in the top level gaia folder which seems strange to me as we also have a test_media folder. For now I'm going to propose moving this into the test_media folder to clean things up a bit, and perhaps we can fix the other folders in there as well.
Summary: Move media-samples folder → Move media-samples folder into test_media
Attached file Github pull request
Hey Guys - any chance for a quick review here? Thanks!
Attachment #8432203 - Flags: review?(yurenju.mozilla)
Attachment #8432203 - Flags: review?(dflanagan)
Comment on attachment 8432203 [details] [review]
Github pull request

that's great, thank you!
Attachment #8432203 - Flags: review?(dflanagan) → review+
Attachment #8432203 - Flags: review?(yurenju.mozilla) → review?(dflanagan)
Comment on attachment 8432203 [details] [review]
Github pull request

I'll just go with one review for now, thanks Yuren! David - feel free to follow-up if you have any concerns. Thanks.
Attachment #8432203 - Flags: review?(dflanagan)
Landed: https://github.com/mozilla-b2g/gaia/commit/7966f664e2120848b0e3dd43c1ec117c5a76f8a7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
You need to log in before you can comment on or make changes to this bug.