10188 - Magic number used in the code without comment

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[Doug Turner (:dougt)]

nitpick, well sorta, I have no idea what these numbers mean:

http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsWinProfileItem.cpp#55
http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsWinRegItem.cpp#100

Comment 1

[Doug Turner (:dougt)]

Moving to M10.

Comment 2

[Doug Turner (:dougt)]

Setting Priority and Serverity per Jan's email.

Comment 3

[Sean Su]

fixed.  These functions were not being called.  I took them out.  There really
isn't a way to verify this unless qa looks at the source code.  Or search for
"GetInstallOrder" via lxr (http://lxr.mozilla.org/seamonkey/) to make sure it's
no longer in the code.

Comment 4

[Jimmy Lee]

Build 8/27/99

Marking Verified.  If the functions are called, then a new bug will be entered
indicating the problem.

Comment 5

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0eefb5ce06e
[components] Issue https://github.com/mozilla-mobile/android-components/issues/10188: Add UI components for displaying a list of branches for a Nimbus experiment
https://hg.mozilla.org/integration/autoland/rev/8fee477a1aaa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10188: Fix xml indentations and properties order.
https://hg.mozilla.org/integration/autoland/rev/b36a4c1a8f62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10188: Fix layout constraints.