1018811 - updated account name not reflected in "Reported" field of bugs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: screen shot

I just came back from vacation and updated my Bugzilla account name to remove the dates I'm away.  When I look at a bug that I reported, my old Bugzilla account name is still used.  Comments from me on the same bug show the new name.  See the attached screenshot.

Comment 1

[Cameron McCormack (:heycam)]

Looking at bugs today, the name appears correct.

Comment 2

[:glob ✱]

looks like editing your account information updates the profiles table directly instead of using the user object.  this is a problem with the memcached backport, as upstream/trunk uses the user object.

Comment 3

[:glob ✱]

Attachment: 1018811_1.patch

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8433086 [details] [diff] [review]
1018811_1.patch

Review of attachment 8433086 [details] [diff] [review]:
-----------------------------------------------------------------

Works well. r=dkl

::: Bugzilla/User.pm
@@ +184,5 @@
>  
>      if (exists $changes->{login_name}) {
> +        # Delete all the tokens related to the userid
> +        $dbh->do('DELETE FROM tokens WHERE userid = ?', undef, $self->id)
> +          unless $options->{keep_tokens};

nit: 4 space indent unless we are doing 2 spaces now but your other changes are 4 spaces :)

Comment 5

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #4)
> >      if (exists $changes->{login_name}) {
> > +        # Delete all the tokens related to the userid
> > +        $dbh->do('DELETE FROM tokens WHERE userid = ?', undef, $self->id)
> > +          unless $options->{keep_tokens};
> 
> nit: 4 space indent unless we are doing 2 spaces now but your other changes
> are 4 spaces :)

some upstream developers use 2 spaces for indentation of continued lines, which was the case in the code i backported here.

Comment 6

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b5039f7..b56bcda  master -> master