Closed Bug 1018811 Opened 7 years ago Closed 7 years ago

updated account name not reflected in "Reported" field of bugs

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: heycam, Assigned: glob)

Details

Attachments

(2 files)

Attached image screen shot β€”
I just came back from vacation and updated my Bugzilla account name to remove the dates I'm away.  When I look at a bug that I reported, my old Bugzilla account name is still used.  Comments from me on the same bug show the new name.  See the attached screenshot.
Assignee: ui → nobody
Component: User Interface → Extensions: UserProfile
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production
Component: Extensions: UserProfile → General
Looking at bugs today, the name appears correct.
looks like editing your account information updates the profiles table directly instead of using the user object.  this is a problem with the memcached backport, as upstream/trunk uses the user object.
Assignee: nobody → glob
Severity: normal → major
Attached patch 1018811_1.patch β€” β€” Splinter Review
Attachment #8433086 - Flags: review?(dkl)
Comment on attachment 8433086 [details] [diff] [review]
1018811_1.patch

Review of attachment 8433086 [details] [diff] [review]:
-----------------------------------------------------------------

Works well. r=dkl

::: Bugzilla/User.pm
@@ +184,5 @@
>  
>      if (exists $changes->{login_name}) {
> +        # Delete all the tokens related to the userid
> +        $dbh->do('DELETE FROM tokens WHERE userid = ?', undef, $self->id)
> +          unless $options->{keep_tokens};

nit: 4 space indent unless we are doing 2 spaces now but your other changes are 4 spaces :)
Attachment #8433086 - Flags: review?(dkl) → review+
(In reply to David Lawrence [:dkl] from comment #4)
> >      if (exists $changes->{login_name}) {
> > +        # Delete all the tokens related to the userid
> > +        $dbh->do('DELETE FROM tokens WHERE userid = ?', undef, $self->id)
> > +          unless $options->{keep_tokens};
> 
> nit: 4 space indent unless we are doing 2 spaces now but your other changes
> are 4 spaces :)

some upstream developers use 2 spaces for indentation of continued lines, which was the case in the code i backported here.
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   b5039f7..b56bcda  master -> master
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.