Closed Bug 1018819 Opened 10 years ago Closed 10 years ago

[Contacts] TAG_OPTIONS should be separated from contacts.js

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mbudzynski, Assigned: mbudzynski)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
TAG_OPTIONS in contacts.js is used in different views as well, so separating it should be the first step in preparing for Haidification.
First WIP patch, testing if nothing broke because of the change: https://github.com/michalbe/gaia/commit/6be285ac959e225ae57ff1cfa7fac53101a48db2
There is probably an error in new L10N library, investigating it with francisco & stas now.
Attached file Patch (obsolete) — 
The patch works on the device, does not work in Nightly. Stas is trying to investigate why.
Attachment #8432417 - Flags: review?(francisco)
Attachment #8432417 - Flags: review?(francisco)
I cancel the R? request because one of the tests is failing.
Attached file Patch — 

        Attachment #8432417 -
        Attachment is obsolete: true

        Attachment #8432417 -
        Flags: review?(francisco)

        Attachment #8433058 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8433058 [details] [review]
Patch

Cleaning the review flag since I left some comments on the bug.

We also agreed to remove the tag parameter in the form detail since we will have it as a global variable now.

Thanks! Flag for review again when ready.

        Attachment #8433058 -
        Flags: review?(francisco)

    
  
Depends on: 1019113

    
  

        Attachment #8433058 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8433058 [details] [review]
Patch

Great, thanks for addressing all the comments.

Tested on FN and working well. Also travis is green, so please go ahead and merge. \o/

        Attachment #8433058 -
        Flags: review?(francisco) → review+

    
    

    
  
Merged: https://github.com/mozilla-b2g/gaia/commit/d698d57f71478e992fd019986d05bccf4b602fa8

Gracias amigo!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: