Closed Bug 1018852 Opened 8 years ago Closed 8 years ago

Mechanism to migrate collections and bookmarks to datastores

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

No description provided.
Assignee: nobody → crdlc
Blocks: 1017069
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Attached file Github pull request
Attachment #8432532 - Flags: review?(kgrandon)
Comment on attachment 8432532 [details]
Github pull request

I have not tested it as the pieces are not there yet to make that reasonable to do so, but the code looks good to me. Really nice work!
Attachment #8432532 - Flags: review?(kgrandon) → review+
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/19e0879b01de9ae0a10855b40b9ea8eca4394355
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Great work Crisitian!

I have one comment - in the new homescreen `providerId` was renamed to `categoryId`
(cf. https://github.com/mozilla-b2g/gaia/blob/master/apps/collection/js/objects.js#L32)

can you please add that to the migration?


also, there is additional data stored by E.me in the CollectionSettings but we can add that later:
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Collection/Collection.js#L616-L646

Thank you!
Blocks: 1019534
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.